Add typing annotations to detection/rpn #4619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
oke-aditya
commented
Oct 14, 2021
|
Thanks for the PR @oke-aditya. All changes look good to me. We just need to take care of the issue you marked here #4619 (comment) and we should be good to go :) |
datumbox
approved these changes
Oct 15, 2021
mszhanyi
pushed a commit
to mszhanyi/vision
that referenced
this pull request
Oct 19, 2021
* Annotate rpn * Small fix * Small fix and ignore Co-authored-by: Vasilis Vryniotis <[email protected]>
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 19, 2021
Summary: * Annotate rpn * Small fix * Small fix and ignore Reviewed By: NicolasHug Differential Revision: D31758315 fbshipit-source-id: 4d16ddc96f26f4c01676cf2f9f6ab3208917ad8a Co-authored-by: Vasilis Vryniotis <[email protected]>
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
* Annotate rpn * Small fix * Small fix and ignore Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #4582
Sorry for the flood of PRs, I luckily have couple of days holiday 😅
cc @datumbox