Fix RoiAlign aligned=True export

[jiafatom]

The original code on aligned=True is not a complete solution and causes result mismatch.
The correct way is to have ONNX RoiAlign updated, that we have done recently for RoiAlign-16.
Therefore we have a fix here to handle aligned=True case.

cc @neginraoof

[jiafatom]

cc @fmassa @datumbox Could you please sign off? Thanks.

[jiafatom]

friendly ping @fmassa @datumbox @pmeier @NicolasHug, thanks

[prabhat00155]

Thanks @jiafatom for the PR!

[prabhat00155]

Thanks @jiafatom, looks good to me. You may need to resolve the merge conflicts, before we can merge this.

[jiafatom]

Thanks @jiafatom, looks good to me. You may need to resolve the merge conflicts, before we can merge this.

I am a little confused here, the conflicting files are just my changes, why it shows to conflicting files? Or what is the best way to do here?

[prabhat00155]

Thanks @jiafatom, looks good to me. You may need to resolve the merge conflicts, before we can merge this.

I am a little confused here, the conflicting files are just my changes, why it shows to conflicting files? Or what is the best way to do here?

You don't have the latest changes in your branch. Check this:

vision/torchvision/ops/_register_onnx_ops.py

Line 25 in 7839bdb

batch_indices = _cast_Long(

.
Just fetch and merge the latest main, resolve the merge conflicts and update your PR. I can update this for you, if you are having issues with this.

[jiafatom]

Thanks @jiafatom, looks good to me. You may need to resolve the merge conflicts, before we can merge this.

I am a little confused here, the conflicting files are just my changes, why it shows to conflicting files? Or what is the best way to do here?

You don't have the latest changes in your branch. Check this:

vision/torchvision/ops/_register_onnx_ops.py

Line 25 in 7839bdb

batch_indices = _cast_Long(

.
Just fetch and merge the latest main, resolve the merge conflicts and update your PR. I can update this for you, if you are having issues with this.

Thanks, done :)

[prabhat00155]

@jiafatom You are getting some linter errors. You may need to run the code formatter locally and update the PR. Look at this https://github.com/pytorch/vision/blob/main/CONTRIBUTING.md#formatting.

[github-actions]

Hey @prabhat00155!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py