Skip to content

Skip test_roi_align_aligned #5029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

prabhat00155
Copy link
Contributor

@prabhat00155 prabhat00155 commented Dec 4, 2021

Resolves #5017.
ROIAlign with aligned=True is not supported in ONNX, see #4692.

cc @pmeier @neginraoof

@facebook-github-bot
Copy link

facebook-github-bot commented Dec 4, 2021

💊 CI failures summary and remediations

As of commit 8a2a287 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build unittest_linux_gpu_py3.8 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

raise error_metas[0].to_error()
=================================== FAILURES ===================================

�[31m�[1m___________________ TestDeformConv.test_autocast[dtype1-33] ____________________�[0m

Traceback (most recent call last):

  File "/home/circleci/project/test/test_ops.py", line 940, in test_autocast

    self.test_forward(torch.device("cuda"), contiguous=False, batch_sz=batch_sz, dtype=dtype)

  File "/home/circleci/project/test/test_ops.py", line 820, in test_forward

    torch.testing.assert_close(

  File "/home/circleci/project/env/lib/python3.8/site-packages/torch/testing/_comparison.py", line 1217, in assert_close

    assert_equal(

  File "/home/circleci/project/env/lib/python3.8/site-packages/torch/testing/_comparison.py", line 997, in assert_equal

    raise error_metas[0].to_error()

AssertionError: 

res:

tensor([[[[-7.5684e-02,  1.0931e-01,  2.5208e-02],

          [-6.7186e-04, -4.5105e-02, -2.1692e-01]],



         [[-1.4392e-01, -3.3740e-01, -2.0007e-01],

          [-2.5684e-01, -2.6562e-01, -5.9662e-02]]],





        [[[-4.7168e-01, -1.9409e-01,  1.8250e-01],


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prabhat00155

@prabhat00155 prabhat00155 merged commit a3d8719 into pytorch:main Dec 5, 2021
@prabhat00155 prabhat00155 deleted the prabhat00155/fix_onnx_test branch December 5, 2021 12:15
@github-actions
Copy link

github-actions bot commented Dec 5, 2021

Hey @prabhat00155!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@prabhat00155 prabhat00155 added the other if you have no clue or if you will manually handle the PR in the release notes label Dec 5, 2021
facebook-github-bot pushed a commit that referenced this pull request Dec 9, 2021
Reviewed By: NicolasHug

Differential Revision: D32950936

fbshipit-source-id: 2a75dc1bfe6f0c1f8616258814400505f5c291ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/default cla signed module: onnx module: tests other if you have no clue or if you will manually handle the PR in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unittest_onnx test failure
3 participants