port RandomPhotoMetricDistort to prototype transforms #5663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 408b98f (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
pmeier
commented
Mar 23, 2022
7 tasks
datumbox
approved these changes
Mar 31, 2022
There was a problem hiding this comment.
The implementation looks good. The problem is that this approach is bound to be quite slow as there will be lots of dispatching involved. When later we try to make the transforms as fast as possible, what are we going todo? We would need to remove the composability that you have and call the low-level kernels.
I'm OK to merge now as we shouldn't try to optimize the speed prematurely but that's something to keep in mind if we keep using composition as an idiom from many other transforms.
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
Reviewed By: NicolasHug Differential Revision: D35393168 fbshipit-source-id: 2a81cb6eaf15a3082826940f1aae14cd862bbc35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5542