Skip to content

Fix py37 warning #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2018
Merged

Fix py37 warning #600

merged 1 commit into from
Sep 11, 2018

Conversation

ssnl
Copy link
Contributor

@ssnl ssnl commented Sep 11, 2018

Warning message:

/private/home/ssnl/miniconda3/lib/python3.7/site-packages/torchvision-0.2.1-py3.7.egg/torchvision/transforms/functional.py:261: DeprecationWarning: Using or importing the ABCs from 'collections' instead of
from 'collections.abc' is deprecated, and in 3.8 it will stop working

fmassa
fmassa approved these changes Sep 11, 2018
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ssnl
Copy link
Contributor Author

ssnl commented Sep 11, 2018

@fmassa Can you merge this? I don't have the rights. :)

@soumith soumith merged commit f91a182 into pytorch:master Sep 11, 2018
@fmassa
Copy link
Member

fmassa commented Sep 11, 2018

Oh sorry, I was waiting for CI to finish, but then I went back home before it was over

@ssnl ssnl deleted the abc branch September 11, 2018 22:49
@ssnl
Copy link
Contributor Author

ssnl commented Sep 11, 2018

@fmassa No worries!

@vishwakftw vishwakftw mentioned this pull request Mar 4, 2019
Closed
@adamjstewart adamjstewart mentioned this pull request Oct 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssnl @fmassa @soumith