Skip to content

Removing uneccesary sys comparison for collections objects #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

surgan12
Copy link
Contributor

@surgan12 surgan12 commented Mar 3, 2019

currently we use :

Sequence = collections.abc.Sequence
Iterable = collections.abc.Iterable
For python versions >= 3.3

But i noticed that
Sequence = collections.Sequence
Iterable = collections.Iterable
works for python >=3.3 as well

Also added tests if this behaviour changes in the future.

cc: @fmassa

@codecov-io
Copy link

codecov-io commented Mar 3, 2019

Codecov Report

Merging #776 into master will decrease coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #776      +/-   ##
==========================================
- Coverage   40.99%   40.71%   -0.28%     
==========================================
  Files          29       29              
  Lines        2747     2741       -6     
  Branches      432      430       -2     
==========================================
- Hits         1126     1116      -10     
- Misses       1542     1545       +3     
- Partials       79       80       +1
Impacted Files Coverage Δ
torchvision/transforms/transforms.py 83.29% <100%> (-0.12%) ⬇️
torchvision/transforms/functional.py 68.91% <100%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc4970...63e9de7. Read the comment docs.

@vishwakftw
Copy link
Contributor

vishwakftw commented Mar 4, 2019

Please note the description in #600.

@surgan12
Copy link
Contributor Author

surgan12 commented Mar 4, 2019

@vishwakftw Thanks !!
Didnt see that though , my bad !
Sorry for bothering.

@surgan12 surgan12 closed this Mar 4, 2019
@vishwakftw
Copy link
Contributor

No worries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants