cleanup prototype auto augment transforms #6463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Aug 22, 2022
datumbox
previously approved these changes
Aug 22, 2022
| image = pil_to_tensor(orig_image) | ||
| def _transform(self, inpt: Any, params: Dict[str, Any]) -> Any: | ||
| if isinstance(inpt, features.Image) or is_simple_tensor(inpt): | ||
| image = inpt |
There was a problem hiding this comment.
Nit: We should start renaming image to inpt. Videos will be passed here soon.
pmeier
commented
Aug 22, 2022
datumbox
approved these changes
Aug 23, 2022
pmeier
added a commit
to pmeier/vision
that referenced
this pull request
Aug 25, 2022
This reverts commit d8025b9.
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 25, 2022
Summary: * cleanup prototype auto augment transforms * remove custom fill parsing from auto augment Reviewed By: datumbox Differential Revision: D39013684 fbshipit-source-id: d0fd5329d9a672024dc0659f1153e8833e35622c
datumbox
added a commit
that referenced
this pull request
Aug 25, 2022
* fix passtrough on transforms and add dispatchers for five and ten crop * Revert "cleanup prototype auto augment transforms (#6463)" This reverts commit d8025b9. * use legacy kernels in deprecated Grayscale and RandomGrayscale transforms * fix default type for Lambda transform * fix default type for ToDtype transform * move simple_tensor to features module * [skip ci] * Revert "move simple_tensor to features module" This reverts commit 7043b6e. * cleanup * reinstate valid AA changes * address review * Fix linter Co-authored-by: Vasilis Vryniotis <[email protected]>
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
Summary: * fix passtrough on transforms and add dispatchers for five and ten crop * Revert "cleanup prototype auto augment transforms (#6463)" This reverts commit d8025b9. * use legacy kernels in deprecated Grayscale and RandomGrayscale transforms * fix default type for Lambda transform * fix default type for ToDtype transform * move simple_tensor to features module * [skip ci] * Revert "move simple_tensor to features module" This reverts commit 7043b6e. * cleanup * reinstate valid AA changes * address review * Fix linter Reviewed By: NicolasHug Differential Revision: D39131014 fbshipit-source-id: 0237a0e2a8256cf7ec5f5bc3b529e471c465ea04 Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While going through the codebase with @vfdev-5 and @datumbox, we noticed that the auto augment transforms were not using the
_get_params/_transformidiom. Looking into it, I don't think there is currently a reason to not do that. I guess this was a limitation of the past design.