Cleanup of prototype transforms #6492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d8025b9.
pmeier
requested review from
datumbox and
vfdev-5
and removed request for
datumbox
datumbox
reviewed
Aug 25, 2022
datumbox
approved these changes
Aug 25, 2022
| def forward(self, *inputs: Any) -> Any: | ||
| sample = inputs if len(inputs) > 1 else inputs[0] | ||
|
|
||
| id, image = self._extract_image(sample) |
There was a problem hiding this comment.
Rant: Not massive fan of using image naming here but we can change once we introduce videos.
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
Summary: * fix passtrough on transforms and add dispatchers for five and ten crop * Revert "cleanup prototype auto augment transforms (#6463)" This reverts commit d8025b9. * use legacy kernels in deprecated Grayscale and RandomGrayscale transforms * fix default type for Lambda transform * fix default type for ToDtype transform * move simple_tensor to features module * [skip ci] * Revert "move simple_tensor to features module" This reverts commit 7043b6e. * cleanup * reinstate valid AA changes * address review * Fix linter Reviewed By: NicolasHug Differential Revision: D39131014 fbshipit-source-id: 0237a0e2a8256cf7ec5f5bc3b529e471c465ea04 Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit in this PR addresses some points flagged in #6486.