[Keyboard] Add Rubrehaku #24907

itsme-zeix · 2025-02-09T05:23:16Z

Description

Add support for Rubrehaku

Types of Changes

Issues Fixed or Closed by This PR

None

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/zeix/singa/rubrehaku/keyboard.json

dunk2k · 2025-02-10T08:36:01Z

@itsme-zeix
In layout LAYOUT_all, when compared to the other layouts is the missing top right key intentional?

dunk2k · 2025-02-10T16:26:38Z

@itsme-zeix In layout LAYOUT_all, when compared to the other layouts is the missing top right key intentional?

Or should it be that all layouts don't have a top right key? as shown in matrix_diagram.md

If correct, then community_layouts should be removed

itsme-zeix · 2025-02-10T16:39:39Z

@itsme-zeix In layout LAYOUT_all, when compared to the other layouts is the missing top right key intentional?

Or should it be that all layouts don't have a top right key? as shown in matrix_diagram.md

If correct, then community_layouts should be removed

@dunk2k Thank you. Appreciate the quick review.
All layouts should not have a top right key - though the functionality is identical with or without it. Removing community_layouts makes sense, no wonder I was having compilation issues.

github-actions · 2025-03-28T02:07:31Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

itsme-zeix · 2025-03-28T02:22:11Z

Doesn’t seem like I can change the stale label :(

keyboards/zeix/singa/rubrehaku/keyboard.json

keyboards/zeix/singa/rubrehaku/keymaps/default/keymap.c

itsme-zeix · 2025-03-29T12:58:22Z

@waffle87 Thank you for the review! I have committed the relevant changes that you have suggested.

github-actions · 2025-06-22T02:16:53Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

itsme-zeix · 2025-06-22T07:20:08Z

Bumping this PR for another review and merge.

keyboards/zeix/singa/rubrehaku/readme.md

keyboards/zeix/singa/rubrehaku/matrix_diagram.md

github-actions · 2025-08-21T02:10:42Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions · 2025-09-21T02:12:43Z

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

* upstream/master: (24 commits) Bump actions/checkout from 4 to 6 (qmk#25829) QMK CLI Environment bootstrapper (qmk#25038) Add Demod LM Rev. 1 (qmk#25793) Add support for Coffee Break Keyboards' Coffeevan (qmk#25805) [Keyboard] Add Keenome Keys' "The Grid v2" (qmk#25813) Bump actions/checkout from 5 to 6 (qmk#25807) [Keyboard] Add Coffee Break Keyboards Acai (qmk#25796) Short term fix for skip_converter KeyError in 'qmk userspace-add' (qmk#25798) Hyper7 v4 (qmk#25728) Add imi60-HS (qmk#25773) Fix detection of hid bootloader flashing tool (qmk#25790) VIA Keylog Change (qmk#25504) [Bugfix] QP error handling (qmk#25591) [Keyboard] Add Rubrehaku (qmk#24907) Fix pmw33xx sensor initialisation (qmk#25777) Add LED index map to `qmk info` cli command (qmk#25743) Bump actions/download-artifact from 5 to 6 (qmk#25746) Bump actions/upload-artifact from 4 to 5 (qmk#25745) Bump JamesIves/github-pages-deploy-action from 4.7.3 to 4.7.4 (qmk#25771) Deprecate LAYOUT() macro in favor of JSON matrix definitions ...

github-actions bot added keyboard keymap labels Feb 9, 2025

itsme-zeix marked this pull request as draft February 9, 2025 05:28

itsme-zeix marked this pull request as ready for review February 9, 2025 05:45

trnthsn reviewed Feb 10, 2025

View reviewed changes

keyboards/zeix/singa/rubrehaku/keyboard.json Outdated Show resolved Hide resolved

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Mar 28, 2025

waffle87 reviewed Mar 28, 2025

View reviewed changes

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Mar 29, 2025

itsme-zeix requested a review from waffle87 May 7, 2025 18:44

itsme-zeix closed this May 7, 2025

itsme-zeix reopened this May 7, 2025

waffle87 approved these changes May 7, 2025

View reviewed changes

waffle87 requested a review from a team May 7, 2025 18:50

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 22, 2025

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jun 23, 2025

waffle87 reviewed Jun 27, 2025

View reviewed changes

keyboards/zeix/singa/rubrehaku/readme.md Outdated Show resolved Hide resolved

keyboards/zeix/singa/rubrehaku/readme.md Outdated Show resolved Hide resolved

waffle87 requested a review from a team June 27, 2025 19:45

fauxpark approved these changes Jul 6, 2025

View reviewed changes

zvecr requested changes Jul 6, 2025

View reviewed changes

keyboards/zeix/singa/rubrehaku/matrix_diagram.md Show resolved Hide resolved

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Aug 21, 2025

github-actions bot closed this Sep 21, 2025

itsme-zeix added 3 commits October 26, 2025 00:50

Add Rubrehaku

c9ff7b2

Format JSON

d27b6cc

Minor fixes

4621278

waffle87 reopened this Oct 25, 2025

waffle87 mentioned this pull request Oct 25, 2025

[Keyboard] Add Rubrehaku #25748

Closed

14 tasks

github-actions bot added core documentation CI dd Data Driven Changes and removed stale Issues or pull requests that have become inactive without resolution. labels Oct 25, 2025

itsme-zeix force-pushed the rubrehaku branch from 63093c1 to 4621278 Compare October 26, 2025 06:59

itsme-zeix changed the title ~~Add Rubrehaku~~ [Keyboard] Add Rubrehaku Oct 26, 2025

itsme-zeix requested a review from zvecr October 26, 2025 14:17

zvecr removed core documentation CI dd Data Driven Changes labels Oct 26, 2025

zvecr approved these changes Nov 8, 2025

View reviewed changes

zvecr merged commit 024c4ef into qmk:master Nov 8, 2025
5 checks passed

drewish mentioned this pull request Nov 18, 2025

Add support for Coffee Break Keyboards Acai #25796

Merged

14 tasks

coldwateryu pushed a commit to coldwateryu/qmk_firmware that referenced this pull request Nov 24, 2025

[Keyboard] Add Rubrehaku (qmk#24907)

10f0b43

eth4nH pushed a commit to eth4nH/yunzii_firmware that referenced this pull request Dec 4, 2025

[Keyboard] Add Rubrehaku (qmk#24907)

8364373

itsme-zeix mentioned this pull request Dec 4, 2025

Add Rubrehaku the-via/qmk_userspace_via#128

Open

4 tasks

versality pushed a commit to versality/qmk_firmware that referenced this pull request Dec 10, 2025

[Keyboard] Add Rubrehaku (qmk#24907)

b22d11d

Uh oh!

[Keyboard] Add Rubrehaku #24907

[Keyboard] Add Rubrehaku #24907

Uh oh!

Conversation

itsme-zeix commented Feb 9, 2025

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

Uh oh!

Uh oh!

dunk2k commented Feb 10, 2025

Uh oh!

dunk2k commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itsme-zeix commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2025

Uh oh!

itsme-zeix commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

itsme-zeix commented Mar 29, 2025

Uh oh!

github-actions bot commented Jun 22, 2025

Uh oh!

itsme-zeix commented Jun 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 21, 2025

Uh oh!

github-actions bot commented Sep 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dunk2k commented Feb 10, 2025 •

edited

Loading

itsme-zeix commented Feb 10, 2025 •

edited

Loading

itsme-zeix commented Mar 28, 2025 •

edited

Loading