Skip to content

VIA Keylog Change #25504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tzarc merged 6 commits into from
Nov 11, 2025
Merged

VIA Keylog Change #25504

tzarc merged 6 commits into from
Nov 11, 2025

Conversation

@Cipulot
Copy link
Contributor

@Cipulot Cipulot commented Jul 19, 2025 •
edited
Loading

Description

After looking at the changes proposed and merged in #25414 , I have added a further check.

The main issue was, as mentioned by zvecr, that using the secure functionality may go over the memory usage allowance. Therefore, using a simple definition was chosen.
While this isn't an issue at all, I think a slightly more comprehensive check could be used.
This PR allows the use of the simple definition of VIA_INSECURE in case the memory allowance is strict, or using the already implemented SECURE status check in case it's possible.
The checks encourage the use of either one, but not both at the same time. If that happens, it goes to default 0 in the readings, since if the SECURE is available, that should be preferred.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jul 19, 2025
@Cipulot Cipulot changed the title WIP VIA Keylog Change Jul 19, 2025
drashna
drashna reviewed Jul 20, 2025
View reviewed changes
Cipulot added 2 commits July 20, 2025 16:46
@Cipulot
Update via.c
1d94424 
temptive fix in formatting for lint errors.
@Cipulot
Update via.c
acaee3b 
let's try this one, thanks mobile GitHub app to not showing spaces right.
@Cipulot
Copy link
Contributor Author

Cipulot commented Jul 20, 2025

@drashna fixed the lint 👍

zvecr
zvecr requested changes Jul 28, 2025
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VIA_INSECURE should just take precedence, especially given the build warning.

Cipulot and others added 2 commits July 28, 2025 22:13
@Cipulot @zvecr
Update quantum/via.c
7f078d1 
Co-authored-by: Joel Challis <[email protected]>
@Cipulot @zvecr
Update quantum/via.c
03a8477 
Co-authored-by: Joel Challis <[email protected]>
@Cipulot
Copy link
Contributor Author

Cipulot commented Jul 28, 2025

Noted @zvecr , applied the suggestions. Thanks 👍

@Cipulot Cipulot mentioned this pull request Jul 30, 2025
Draft
14 tasks
@Cipulot Cipulot changed the base branch from develop to master September 9, 2025 22:34
@github-actions
Copy link

github-actions bot commented Oct 25, 2025

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 25, 2025
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 27, 2025
@tzarc tzarc self-assigned this Oct 27, 2025
@tzarc tzarc merged commit ed343dd into qmk:master Nov 11, 2025
4 checks passed
@Cipulot Cipulot deleted the via_keylog_change branch November 13, 2025 12:41
@drewish drewish mentioned this pull request Nov 18, 2025
Merged
14 tasks
coldwateryu pushed a commit to coldwateryu/qmk_firmware that referenced this pull request Nov 24, 2025
@Cipulot @milan-tradecore
VIA Keylog Change (qmk#25504)
e9261b3 
* WIP

* Update via.c

temptive fix in formatting for lint errors.

* Update via.c

let's try this one, thanks mobile GitHub app to not showing spaces right.

* Update quantum/via.c

Co-authored-by: Joel Challis <[email protected]>

* Update quantum/via.c

Co-authored-by: Joel Challis <[email protected]>

* Merge branch 'qmk:master' into via_keylog_change
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Nov 29, 2025
Merge remote-tracking branch 'upstream/master' into cadusk
76a5a91 
* upstream/master: (24 commits)
  Bump actions/checkout from 4 to 6 (qmk#25829)
  QMK CLI Environment bootstrapper (qmk#25038)
  Add Demod LM Rev. 1 (qmk#25793)
  Add support for Coffee Break Keyboards' Coffeevan (qmk#25805)
  [Keyboard] Add Keenome Keys' "The Grid v2" (qmk#25813)
  Bump actions/checkout from 5 to 6 (qmk#25807)
  [Keyboard] Add Coffee Break Keyboards Acai (qmk#25796)
  Short term fix for skip_converter KeyError in 'qmk userspace-add' (qmk#25798)
  Hyper7 v4 (qmk#25728)
  Add imi60-HS (qmk#25773)
  Fix detection of hid bootloader flashing tool (qmk#25790)
  VIA Keylog Change (qmk#25504)
  [Bugfix] QP error handling (qmk#25591)
  [Keyboard] Add Rubrehaku (qmk#24907)
  Fix pmw33xx sensor initialisation (qmk#25777)
  Add LED index map to `qmk info` cli command (qmk#25743)
  Bump actions/download-artifact from 5 to 6 (qmk#25746)
  Bump actions/upload-artifact from 4 to 5 (qmk#25745)
  Bump JamesIves/github-pages-deploy-action from 4.7.3 to 4.7.4 (qmk#25771)
  Deprecate LAYOUT() macro in favor of JSON matrix definitions
  ...
eth4nH pushed a commit to eth4nH/yunzii_firmware that referenced this pull request Dec 4, 2025
@Cipulot @eth4nH
VIA Keylog Change (qmk#25504)
add0094 
* WIP

* Update via.c

temptive fix in formatting for lint errors.

* Update via.c

let's try this one, thanks mobile GitHub app to not showing spaces right.

* Update quantum/via.c

Co-authored-by: Joel Challis <[email protected]>

* Update quantum/via.c

Co-authored-by: Joel Challis <[email protected]>

* Merge branch 'qmk:master' into via_keylog_change
versality pushed a commit to versality/qmk_firmware that referenced this pull request Dec 10, 2025
@Cipulot @versality
VIA Keylog Change (qmk#25504)
eb35886 
* WIP

* Update via.c

temptive fix in formatting for lint errors.

* Update via.c

let's try this one, thanks mobile GitHub app to not showing spaces right.

* Update quantum/via.c

Co-authored-by: Joel Challis <[email protected]>

* Update quantum/via.c

Co-authored-by: Joel Challis <[email protected]>

* Merge branch 'qmk:master' into via_keylog_change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

@zvecr zvecr zvecr approved these changes

+1 more reviewer

@dexter93 dexter93 dexter93 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tzarc tzarc

Labels

awaiting review core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Cipulot @dexter93 @drashna @tzarc @zvecr