Remove numpy<1.24 restriction from requirements.txt#6149
Merged
tanujkhattar merged 4 commits intoquantumlib:masterfrom Jun 22, 2023
Merged
Remove numpy<1.24 restriction from requirements.txt#6149tanujkhattar merged 4 commits intoquantumlib:masterfrom
tanujkhattar merged 4 commits intoquantumlib:masterfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
maffoo
reviewed
Jun 21, 2023
Contributor
maffoo
left a comment
maffoo
left a comment
There was a problem hiding this comment.
Seems fine to update, but do we want to change proper_repr so that it produces valid reprs with the new numpy version?
| "\n", | ||
| "for inp, out in zip(input_states, output_states):\n", | ||
| " result = cirq.Simulator().simulate(c2, initial_state=inp)\n", | ||
| " result = cirq.Simulator(dtype=np.complex128).simulate(c2, initial_state=inp)\n", |
Collaborator
Author
There was a problem hiding this comment.
Thet test started failing for Windows because of precision issues. I didn't dig very deep on whether it's something related to the new release or whether the test was flaky in the first place (probably more likely) so I just increased the precision and it seems to work fine.
The relevant statements in the cell below, that depend on the precision, are:
"inds, = np.where(abs(result.final_state_vector) > 1e-8)\n",
"assert len(inds) == 1\n",
Collaborator
Author
pavoljuhas
approved these changes
Jun 21, 2023
maffoo
approved these changes
Jun 22, 2023
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5967