convert cliffords to xz in qubit characterization#6420
Conversation
NoureldinYosri
requested review from
a team,
cduck,
mrwojtek and
vtomole
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6420 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 1111 1111
Lines 97115 97121 +6
=======================================
+ Hits 94994 95000 +6
Misses 2121 2121 ☔ View full report in Codecov by Sentry. |
| gate_ids = list(np.random.choice(clifford_group_size, num_cfds)) | ||
| adjoint = _reduce_gate_seq([gate for gate_id in gate_ids for gate in cfds[gate_id]]) ** -1 | ||
| return [op for gate_id in gate_ids for op in operations[gate_id]] + [adjoint(qubit)] | ||
| return [op for gate_id in gate_ids for op in operations[gate_id]] + [ |
There was a problem hiding this comment.
I'm surprised that this didn't cause any unit tests to fail.
Can you add a test that validates the generated circuit(s) against a known gateset that resembles what we've already published via the Virtual Quantum Engine? e.g., you might check against a ValidatingTestDevice.
There was a problem hiding this comment.
that's because none of the test examin the internals of the circuits but treat the circuits as blackboxes with a specific behaviour => it checks things like pauli errors and other characterisitics.
added a test for now
wcourtney
left a comment
wcourtney
left a comment
There was a problem hiding this comment.
LGTM, thanks! Just to confirm - the test fails w/o your code change, right?
|
@wcourtney yes |
3 participants
No description provided.