Skip to content

Add workflow for checking PR titles & descriptions#7991

Closed
mhucka wants to merge 10 commits intoquantumlib:mainfrom
mhucka:add-pr-description-check
Closed

Add workflow for checking PR titles & descriptions#7991
mhucka wants to merge 10 commits intoquantumlib:mainfrom
mhucka:add-pr-description-check

Conversation

@mhucka
Copy link
Copy Markdown
Contributor

@mhucka mhucka commented Mar 30, 2026

This workflow adds very simple checks for minimum requirements: a title that has at least two words, and a description that is at least 10 characters long.

In the future, more checks could be added as additional jobs in this workflow. For example, we should also check for the presence of non-inclusive terms such as "blacklist".

This workflow adds very simple checks for minimum requirements: a title
that least two words, and a description that is at least 10 characters
long.

In the future, more checks could be added as additional jobs in this
workflow. For example, we should also check for non-inclusive terms such
as "blacklist" and "whitelist".
@github-actions github-actions bot added the size: M 50< lines changed <250 label Mar 30, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.63%. Comparing base (603755a) to head (a284677).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7991   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        1110     1110           
  Lines       99752    99752           
=======================================
  Hits        99390    99390           
  Misses        362      362           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mhucka mhucka marked this pull request as ready for review March 30, 2026 20:52
@mhucka mhucka requested review from a team and vtomole as code owners March 30, 2026 20:52
Copy link
Copy Markdown
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this is worth the extra maintenance for the new workflow. More than a minimum length it is important for the PR titles and descriptions to be well suited as commit messages which they become because we use merge queue. It should be a part of the review process to ensure that they are in a good shape. Perhaps we should first do a quick maintainers' chat to settle on some good title/description standards if you feel that some of our past PRs could do better.

mhucka and others added 2 commits March 31, 2026 20:44
@mhucka
Copy link
Copy Markdown
Contributor Author

mhucka commented Apr 1, 2026

I agree we should have a maintainers discussion about conventions! And also, I think we should update the written maintainers documentation. Independently of that, IMHO I think a workflow will save us time in the long run by reducing the number of times we have to write comments requesting people to add descriptions to their PRs.

To back up that claim, I checked the last 1000 PRs and here is a list of those that were merged despite having empty descriptions – some even by (ahem) the two of us. This is 51 PRs out of the last 1000 = approx. 5% of PRs.

@mhucka
Copy link
Copy Markdown
Contributor Author

mhucka commented Apr 14, 2026

@Pavol Regarding this, what do you think about making this workflow simply add a comment to the PR requesting the changes, instead of failing the CI workflow altogether?

@mhucka
Copy link
Copy Markdown
Contributor Author

mhucka commented Apr 16, 2026

Closing this for now, pending a re-think.

@mhucka mhucka closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: M 50< lines changed <250

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants