Add workflow for checking PR titles & descriptions#7991
Add workflow for checking PR titles & descriptions#7991mhucka wants to merge 10 commits intoquantumlib:mainfrom
Conversation
This workflow adds very simple checks for minimum requirements: a title that least two words, and a description that is at least 10 characters long. In the future, more checks could be added as additional jobs in this workflow. For example, we should also check for non-inclusive terms such as "blacklist" and "whitelist".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7991 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 1110 1110
Lines 99752 99752
=======================================
Hits 99390 99390
Misses 362 362 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pavoljuhas
left a comment
There was a problem hiding this comment.
I am not sure this is worth the extra maintenance for the new workflow. More than a minimum length it is important for the PR titles and descriptions to be well suited as commit messages which they become because we use merge queue. It should be a part of the review process to ensure that they are in a good shape. Perhaps we should first do a quick maintainers' chat to settle on some good title/description standards if you feel that some of our past PRs could do better.
Shorten and simplify the code a little bit more
|
@Pavol Regarding this, what do you think about making this workflow simply add a comment to the PR requesting the changes, instead of failing the CI workflow altogether? |
|
Closing this for now, pending a re-think. |
This workflow adds very simple checks for minimum requirements: a title that has at least two words, and a description that is at least 10 characters long.
In the future, more checks could be added as additional jobs in this workflow. For example, we should also check for the presence of non-inclusive terms such as "blacklist".