Parallel XEB: Add option to specify pairs

[eliottrosenberg]

No description provided.

[NoureldinYosri]

LGTM%nit

[NoureldinYosri]

Suggested change

	qubits_set = set()
	qubit_set = set(itertools.chain(*pairs))

[NoureldinYosri]

usually new arguments go to the end

[NoureldinYosri]

lets move the new argument pairs to the end of the list

[NoureldinYosri]

extract this logic into a method and use it here and in the other methods

def qubits_and_pairs(
    sampler: 'cirq.Sampler',
    qubits: Optional[Sequence['cirq.GridQubit']] = None,
    pairs: Optional[Sequence[tuple['cirq.GridQubit', 'cirq.GridQubit']]] = None,
) -> Tuple[Sequence['cirq.GridQubit'], Sequence[tuple['cirq.GridQubit', 'cirq.GridQubit']]]:
    """Extract qubits and pairs from sampler.
    

    If qubits are not provided, then they are extracted from the pairs (if given) or the sampler.
    If pairs are not provided then all pairs of adjacent qubits are used.

    Args:
        sampler: The quantum engine or simulator to run the circuits.
        qubits: Optional list of qubits.
        pairs: Optional list of pair to use.
    
    Returns:
        - Qubits to use.
        - Pairs of qubits to use.
    
    Raises:
        ValueError: If qubits are not specified and can't be deduced from other arguments.
    """
    if qubits is None:
        if pairs is None:
            qubits = _grid_qubits_for_sampler(sampler)
            if qubits is None:
                raise ValueError("Couldn't determine qubits from sampler. Please specify them.")
        else:
            qubits_set = set(itertools.chain(*pairs))
            qubits = list(qubits_set)

    if pairs is None:
        pairs = [
            pair for pair in itertools.combinations(qubits, 2) if _manhattan_distance(*pair) == 1
        ]

    return qubits, pairs

[NoureldinYosri]

please make the qubits_and_pairs function public, otherwisenvm, LGTM

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.85%. Comparing base (2c914ce) to head (00917c0).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #6787    +/-   ##
========================================
  Coverage   97.85%   97.85%            
========================================
  Files        1081     1083     +2     
  Lines       93370    93537   +167     
========================================
+ Hits        91364    91528   +164     
- Misses       2006     2009     +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.