Skip to content

Fix misspelled class name in cirq-core/cirq/transformers/noise_adding.py#6716

Merged
eliottrosenberg merged 2 commits intomainfrom
eliottrosenberg-patch-1
Aug 30, 2024
Merged

Fix misspelled class name in cirq-core/cirq/transformers/noise_adding.py#6716
eliottrosenberg merged 2 commits intomainfrom
eliottrosenberg-patch-1

Conversation

@eliottrosenberg
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A test needs to be updated as well.

Copy link
Copy Markdown
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix that name in tests. Otherwise LGTM.

@pavoljuhas
Copy link
Copy Markdown
Collaborator

NTS - This is a new class added in not-yet-released commit 3922a63.
We can rename without going through deprecation process.

@eliottrosenberg eliottrosenberg enabled auto-merge (squash) August 30, 2024 20:58
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.83%. Comparing base (6037f18) to head (8354ad8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6716   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files        1077     1077           
  Lines       92482    92482           
=======================================
  Hits        90480    90480           
  Misses       2002     2002           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eliottrosenberg eliottrosenberg merged commit e16d886 into main Aug 30, 2024
@eliottrosenberg eliottrosenberg deleted the eliottrosenberg-patch-1 branch August 30, 2024 21:19
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
* Update noise_adding.py

* update test
@mhucka mhucka changed the title Fix misspelling in class name Fix misspelling in class name in cirq-core/cirq/transformers/noise_adding_test.py Apr 8, 2025
@mhucka mhucka changed the title Fix misspelling in class name in cirq-core/cirq/transformers/noise_adding_test.py Fix misspelled class name in cirq-core/cirq/transformers/noise_adding_test.py Apr 8, 2025
@mhucka mhucka changed the title Fix misspelled class name in cirq-core/cirq/transformers/noise_adding_test.py Fix misspelled class name in cirq-core/cirq/transformers/noise_adding.py Apr 10, 2025
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
* Update noise_adding.py

* update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants