Skip to content

Support "cu1", "cu3", and "crz" in QasmParser#6820

Merged
vtomole merged 14 commits intoquantumlib:mainfrom
bharat-thotakura:support-more-qasm
Dec 9, 2024
Merged

Support "cu1", "cu3", and "crz" in QasmParser#6820
vtomole merged 14 commits intoquantumlib:mainfrom
bharat-thotakura:support-more-qasm

Conversation

@bharat-thotakura
Copy link
Copy Markdown
Contributor

No description provided.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Dec 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@CirqBot CirqBot added the size: L 250< lines changed <1000 label Dec 6, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.85%. Comparing base (def1b08) to head (a27df98).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6820      +/-   ##
==========================================
- Coverage   97.85%   97.85%   -0.01%     
==========================================
  Files        1084     1084              
  Lines       93870    93904      +34     
==========================================
+ Hits        91860    91891      +31     
- Misses       2010     2013       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Bharath <bharath.thotakura@infleqtion.com>
Signed-off-by: Bharath <bharath.thotakura@infleqtion.com>
@bharat-thotakura bharat-thotakura marked this pull request as ready for review December 6, 2024 23:57
@bharat-thotakura bharat-thotakura requested review from a team and vtomole as code owners December 6, 2024 23:57
@bharat-thotakura bharat-thotakura changed the title Support "cu1", "cu3", "crz", and "reset" in QasmParser Support "cu1", "cu3", and "crz" in QasmParser Dec 6, 2024
Comment thread cirq-core/cirq/contrib/qasm_import/_parser_test.py
Signed-off-by: Bharath <bharath.thotakura@infleqtion.com>
Signed-off-by: Bharath <bharath.thotakura@infleqtion.com>
Signed-off-by: Bharath <bharath.thotakura@infleqtion.com>
Signed-off-by: Bharath <bharath.thotakura@infleqtion.com>
Copy link
Copy Markdown
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Bharath <bharath.thotakura@infleqtion.com>
Signed-off-by: Bharath <bharath.thotakura@infleqtion.com>
Signed-off-by: Bharath <bharath.thotakura@infleqtion.com>
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@vtomole vtomole merged commit e9fbabc into quantumlib:main Dec 9, 2024
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: L 250< lines changed <1000

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants