Skip to content

Enable test_docker_pre after pinning the mpmath transitive dependency#6481

Merged
pavoljuhas merged 2 commits intoquantumlib:mainfrom
pavoljuhas:enable-test_docker_pre
Feb 28, 2024
Merged

Enable test_docker_pre after pinning the mpmath transitive dependency#6481
pavoljuhas merged 2 commits intoquantumlib:mainfrom
pavoljuhas:enable-test_docker_pre

Conversation

@pavoljuhas
Copy link
Copy Markdown
Collaborator

Finalizes #6475

@CirqBot CirqBot added the Size: XS <10 lines changed label Feb 28, 2024
@pavoljuhas
Copy link
Copy Markdown
Collaborator Author

Note - fresh installation of pip install --pre cirq results in broken sympy.
This is fixed by mpmath version pin in #6477.

TODO: submit once #6477 is in the pre-release wheel.

@pavoljuhas pavoljuhas marked this pull request as ready for review February 28, 2024 16:53
@pavoljuhas pavoljuhas requested review from a team, cduck and vtomole as code owners February 28, 2024 16:53
@pavoljuhas pavoljuhas requested a review from viathor February 28, 2024 16:53
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (02d29a9) to head (6b21299).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6481   +/-   ##
=======================================
  Coverage   97.75%   97.76%           
=======================================
  Files        1105     1105           
  Lines       94925    94924    -1     
=======================================
+ Hits        92793    92798    +5     
+ Misses       2132     2126    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas pavoljuhas merged commit eef7c5c into quantumlib:main Feb 28, 2024
@pavoljuhas pavoljuhas deleted the enable-test_docker_pre branch February 28, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: XS <10 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants