fixed mpmath version to 1.3.0 due to incompatibility#6477
Merged
pavoljuhas merged 5 commits intoquantumlib:mainfrom Feb 28, 2024
Merged
fixed mpmath version to 1.3.0 due to incompatibility#6477pavoljuhas merged 5 commits intoquantumlib:mainfrom
pavoljuhas merged 5 commits intoquantumlib:mainfrom
Conversation
pavoljuhas
requested changes
Feb 28, 2024
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
Looks good with a small change.
Please feel free to convert from draft. The main branch currently skips the failing test so the CI should pass for this PR.
Once this PR is in we can re-enable the test, because mpmath pinning will be in effect in the cirq-core pre-release.
|
|
||
| duet>=0.2.8 | ||
| matplotlib~=3.0 | ||
| mpmath~=1.3.0 |
Collaborator
There was a problem hiding this comment.
Thank you for tracking this down!
I think we can use a less restrictive mpmath spec to be in sync with sympy requirement for mpmath>=0.19.
Suggested change
| mpmath~=1.3.0 | |
| # Temporary fix for https://github.com/sympy/sympy/issues/26273 | |
| # TODO: remove once `pip install --pre sympy` works in a fresh environment | |
| mpmath<=1.3.* |
Contributor
Author
There was a problem hiding this comment.
@pavoljuhas
Thank you for comment!
I have reflected the comment and confirmed that it passes the test.
pavoljuhas
approved these changes
Feb 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6477 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 1105 1105
Lines 94925 94925
=======================================
Hits 92793 92793
Misses 2132 2132 ☔ View full report in Codecov by Sentry. |
kenya-sk
added a commit
to kenya-sk/Cirq
that referenced
this pull request
Feb 28, 2024
…quantumlib#6477)" This reverts commit e11132e.
pavoljuhas
added a commit
to pavoljuhas/Cirq
that referenced
this pull request
Mar 29, 2024
…quantumlib#6477)" Not needed after quantumlib#6534 as cirq pre-releases are installed with stable dependencies. This reverts commit e11132e. Related to quantumlib#6475
pavoljuhas
added a commit
that referenced
this pull request
Mar 29, 2024
jselig-rigetti
pushed a commit
to jselig-rigetti/Cirq
that referenced
this pull request
May 28, 2024
Version limit on mpmath is unnecessary after quantumlib#6534 because cirq pre-releases are now installed with stable dependencies. This reverts commit e11132e (quantumlib#6477). Related to quantumlib#6475
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Version limit on mpmath is unnecessary after quantumlib#6534 because cirq pre-releases are now installed with stable dependencies. This reverts commit e11132e (quantumlib#6477). Related to quantumlib#6475
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dealing with CI pipeline failures following upgrades of incompatible packages. (detail issues: #6475)
The error location is
Dockerfilein line 26. This one downloads the package from PyPI, but my permission do not allow me to update the package. Therefore, I have changed the version ofmpmathin my local environment, and I am hoping that the test will pass.