Fix maximum version limit for mpmath#6482
Merged
pavoljuhas merged 1 commit intoquantumlib:mainfrom Feb 28, 2024
Merged
Conversation
The `1.3.*` pattern is invalid in `install_requires` context. The `mpmath<1.4` spec prohibits pre-releases of 1.4 such as 1.4.0a0. Related to quantumlib#6475
Collaborator
Author
|
Fixes packaging related CI failures due to invalid requirement introduced in #6477. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6482 +/- ##
==========================================
- Coverage 97.75% 97.74% -0.01%
==========================================
Files 1105 1105
Lines 94925 94925
==========================================
- Hits 92793 92788 -5
- Misses 2132 2137 +5 ☔ View full report in Codecov by Sentry. |
Contributor
|
@pavoljuhas |
Collaborator
Author
sure, my wrong in the first place for not checking the initial expression. |
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
The `1.3.*` pattern is invalid in `install_requires` context. The `mpmath<1.4` spec prohibits pre-releases of 1.4 such as 1.4.0a0. Related to quantumlib#6475
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
1.3.*pattern is invalid ininstall_requirescontext.The
mpmath<1.4spec prohibits pre-releases of 1.4 such as 1.4.0a0.Related to #6475