Update start notebook to use get_engine instead of get_qcs_objects_for_notebook#6483
Update start notebook to use get_engine instead of get_qcs_objects_for_notebook#6483senecameeks merged 9 commits intoquantumlib:mainfrom
get_engine instead of get_qcs_objects_for_notebook#6483Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6483 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 1105 1105
Lines 94936 94963 +27
=======================================
+ Hits 92810 92837 +27
Misses 2126 2126 ☔ View full report in Codecov by Sentry. |
|
this might not work if it's run from outside corp network in which case authentication is needed which is part of to check if it will from outside corp network try to run then notebook in colab.research |
|
Thanks @NoureldinYosri for the catch! #6485 exposes |
Addresses #6427 by removing the incorrect
processor_idin the notebook.Although this doesn't fix the underlying issue as to why
get_qcs_objects_for_notebookis incorrect and doesn't address Will's second point in his commentFYI, I verified this works as a good replacement for
get_qcs_objects_for_notebook