Expose authenticate_user#6485
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…eks/Cirq into u/smeeks/add_auth_to_get_engine
senecameeks
requested review from
a team,
cduck,
verult and
vtomole
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6485 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 1105 1105
Lines 94936 94957 +21
=======================================
+ Hits 92810 92831 +21
Misses 2126 2126 ☔ View full report in Codecov by Sentry. |
| return get_engine(project_id) | ||
| except Exception as exc: | ||
| print( | ||
| "Authentication failed, you may not have permission to access a" |
There was a problem hiding this comment.
Should the "authentication failed" message occur en the authentication step? e.g., what happens if get_engine raises an exception?
There was a problem hiding this comment.
n/a since this api was removed
| ) | ||
|
|
||
|
|
||
| def get_hardware_engine_and_authenticate_user( |
There was a problem hiding this comment.
The long name makes this function harder to reason about and calling it as just as long as calling the constituent parts. WYDT of exposing authenticate_user and calling that from the notebook instead?
There was a problem hiding this comment.
+1, updated to make authenticate_user public
senecameeks
changed the title
get_hardware_engine_and_authenticate_userauthenticate_user
3 participants
Create and expose new
authenticate_userapiCurrently an API does not exist that returns an engine instance and does authentication.
get_engineassumes the user is in the corp network and will fail for external users without access to corp. (as noted in #6483)