Switch notebooks from dev to stable cirq where possible#7247
Merged
pavoljuhas merged 6 commits intoquantumlib:mainfrom Apr 9, 2025
Merged
Switch notebooks from dev to stable cirq where possible#7247pavoljuhas merged 6 commits intoquantumlib:mainfrom
pavoljuhas merged 6 commits intoquantumlib:mainfrom
Conversation
The notebook actually installs and tests with stable cirq.
…_test.py This notebook is also excluded in notebook_test.py which tests with head cirq.
- calibration_api.ipynb was removed in quantumlib#6580 - operators_and_observables.ipynb was renamed to operators.ipynb and it does not match the operators.txt replacement anymore
mhucka
approved these changes
Apr 8, 2025
Contributor
mhucka
left a comment
mhucka
left a comment
There was a problem hiding this comment.
With the caveat that I didn't try running the notebooks, this LGTM.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7247 +/- ##
==========================================
- Coverage 98.64% 98.64% -0.01%
==========================================
Files 1106 1106
Lines 95990 95990
==========================================
- Hits 94691 94690 -1
- Misses 1299 1300 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 30, 2025
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
) * Remove obsolete note about installing cirq-dev The notebook actually installs and tests with stable cirq. * Switch from dev to stable cirq in notebooks where it works Ref: https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md#lifecycle * Exclude xeb_calibration_example.ipynb notebook from isolated_notebook_test.py This notebook is also excluded in notebook_test.py which tests with head cirq. * Delete unused tst files - calibration_api.ipynb was removed in quantumlib#6580 - operators_and_observables.ipynb was renamed to operators.ipynb and it does not match the operators.txt replacement anymore * Typo `mehod` -> `method`
This was referenced Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert notebooks which already work with stable cirq to
install stable cirq
Delete outdated notes about notebooks needing dev cirq
Delete unused tst files that have no corresponding notebooks
Exclude untested
xeb_calibration_example.ipynbnotebook fromisolated_notebook_test.pyas wellAnd fix one odd typo