Skip to content

Remove notebooks refering to removed service#6580

Merged
NoureldinYosri merged 4 commits intoquantumlib:mainfrom
NoureldinYosri:remove_deprecated
Jan 14, 2025
Merged

Remove notebooks refering to removed service#6580
NoureldinYosri merged 4 commits intoquantumlib:mainfrom
NoureldinYosri:remove_deprecated

Conversation

@NoureldinYosri
Copy link
Copy Markdown
Collaborator

These notebook explain the floquet service which has been recently removed.

@NoureldinYosri NoureldinYosri requested review from a team, cduck and vtomole as code owners May 1, 2024 00:04
@NoureldinYosri NoureldinYosri requested a review from dabacon May 1, 2024 00:04
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@NoureldinYosri NoureldinYosri requested a review from senecameeks May 1, 2024 00:05
Copy link
Copy Markdown
Collaborator

@senecameeks senecameeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are still some references that need to be removed for the CI to pass

@CirqBot CirqBot added the size: XL lines changed >1000 label May 5, 2024
@github-actions github-actions bot added the Stale label Jun 5, 2024
@github-actions github-actions bot closed this Jul 5, 2024
@NoureldinYosri NoureldinYosri reopened this Jul 5, 2024
@github-actions github-actions bot removed the Stale label Jul 6, 2024
@github-actions github-actions bot added the Stale label Aug 5, 2024
@github-actions github-actions bot closed this Sep 4, 2024
@mhucka mhucka added the status/stale Closed due to inactivity for an extended period of time label Nov 18, 2024
@mhucka mhucka reopened this Dec 20, 2024
@github-actions github-actions bot removed the status/stale Closed due to inactivity for an extended period of time label Dec 21, 2024
@dstrain115
Copy link
Copy Markdown
Collaborator

@NoureldinYosri @senecameeks Can we finish this PR off and remove these notebooks? Calibration API was deleted some time ago, and we should remove or augment this documentation.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (988ecbc) to head (f896828).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6580   +/-   ##
=======================================
  Coverage   97.86%   97.87%           
=======================================
  Files        1084     1084           
  Lines       94408    94408           
=======================================
+ Hits        92393    92398    +5     
+ Misses       2015     2010    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NoureldinYosri NoureldinYosri enabled auto-merge (squash) January 14, 2025 20:12
@NoureldinYosri NoureldinYosri merged commit cd9a3ff into quantumlib:main Jan 14, 2025
pavoljuhas added a commit to pavoljuhas/Cirq that referenced this pull request Apr 8, 2025
- calibration_api.ipynb was removed in quantumlib#6580
- operators_and_observables.ipynb was renamed to operators.ipynb and
  it does not match the operators.txt replacement anymore
github-merge-queue bot pushed a commit that referenced this pull request Apr 9, 2025
* Remove obsolete note about installing cirq-dev

The notebook actually installs and tests with stable cirq.

* Switch from dev to stable cirq in notebooks where it works

Ref: https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md#lifecycle

* Exclude xeb_calibration_example.ipynb notebook from isolated_notebook_test.py

This notebook is also excluded in notebook_test.py which tests with head cirq.

* Delete unused tst files

- calibration_api.ipynb was removed in #6580
- operators_and_observables.ipynb was renamed to operators.ipynb and
  it does not match the operators.txt replacement anymore

* Typo `mehod` -> `method`
mhucka added a commit to mhucka/Cirq that referenced this pull request Apr 9, 2025
github-merge-queue bot pushed a commit that referenced this pull request Apr 9, 2025
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
)

* Remove obsolete note about installing cirq-dev

The notebook actually installs and tests with stable cirq.

* Switch from dev to stable cirq in notebooks where it works

Ref: https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md#lifecycle

* Exclude xeb_calibration_example.ipynb notebook from isolated_notebook_test.py

This notebook is also excluded in notebook_test.py which tests with head cirq.

* Delete unused tst files

- calibration_api.ipynb was removed in quantumlib#6580
- operators_and_observables.ipynb was renamed to operators.ipynb and
  it does not match the operators.txt replacement anymore

* Typo `mehod` -> `method`
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
mhucka added a commit to mhucka/Cirq that referenced this pull request Jul 18, 2025
Previously, PR quantumlib#6580 removed notebooks and the faq about calibration
topics that concerned the quantum service that is no longer offered.
However, these links in the TOC were missed at the time and need to be
removed.
github-merge-queue bot pushed a commit that referenced this pull request Jul 18, 2025
Previously, PR #6580 removed notebooks and the faq about calibration
topics that concerned the quantum service that is no longer offered.
However, these links in the TOC were missed at the time and need to be
removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: XL lines changed >1000

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants