Skip to content

pylint - sync with rules used in internal codes#7387

Merged
pavoljuhas merged 5 commits intoquantumlib:mainfrom
pavoljuhas:pylint-sync-with-pyle
May 29, 2025
Merged

pylint - sync with rules used in internal codes#7387
pavoljuhas merged 5 commits intoquantumlib:mainfrom
pavoljuhas:pylint-sync-with-pyle

Conversation

@pavoljuhas
Copy link
Copy Markdown
Collaborator

Activate pylint rules used in pyle and fix flagged issues.

Added pylint rules:

  • abstract-class-instantiated
  • assignment-from-no-return
  • bad-chained-comparison
  • bad-mcs-classmethod-argument
  • bad-mcs-method-argument
  • deprecated-decorator
  • method-hidden
  • raising-bad-type
  • raising-format-tuple
  • redefined-slots-in-subclass
  • self-cls-assignment
  • shadowed-import
  • simplifiable-condition
  • unneeded-not
  • use-maxsplit-arg
  • using-constant-test

Related to #7371

@pavoljuhas pavoljuhas requested review from a team and vtomole as code owners May 29, 2025 18:10
@pavoljuhas pavoljuhas requested a review from maffoo May 29, 2025 18:10
@github-actions github-actions bot added the size: M 50< lines changed <250 label May 29, 2025
@pavoljuhas pavoljuhas enabled auto-merge May 29, 2025 18:18
@pavoljuhas pavoljuhas added this pull request to the merge queue May 29, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (3578631) to head (2ee207e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7387      +/-   ##
==========================================
- Coverage   98.68%   98.68%   -0.01%     
==========================================
  Files        1112     1112              
  Lines       97641    97642       +1     
==========================================
  Hits        96359    96359              
- Misses       1282     1283       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2025
@pavoljuhas pavoljuhas added this pull request to the merge queue May 29, 2025
Merged via the queue into quantumlib:main with commit 12eab31 May 29, 2025
35 checks passed
@pavoljuhas pavoljuhas deleted the pylint-sync-with-pyle branch May 29, 2025 19:02
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
Activate pylint rules used in pyle and fix flagged issues.

Added pylint rules:

- abstract-class-instantiated
- assignment-from-no-return
- bad-chained-comparison
- bad-mcs-classmethod-argument
- bad-mcs-method-argument
- deprecated-decorator
- method-hidden
- raising-bad-type
- raising-format-tuple
- redefined-slots-in-subclass
- self-cls-assignment
- shadowed-import
- simplifiable-condition
- unneeded-not
- use-maxsplit-arg
- using-constant-test

Related to quantumlib#7371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: M 50< lines changed <250

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants