-
Notifications
You must be signed in to change notification settings - Fork 146
Refactor upstream guardrails #1728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor upstream guardrails #1728
Conversation
cc @mariofusco |
This comment has been minimized.
This comment has been minimized.
Refactor to use upstream guardrails. For now I'm leaving the existing Quarkus-specific implementation in place, but fully deprecated. We can decide if we'd like to rip it out as part of this PR, or have both implementations for a little bit of time in order to give people time to transition. Closes quarkiverse#1284
abcaac9
to
cbb10d7
Compare
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edeandrea thanks a lot, amazing job!
I strongly suggest to remove the old guardrails implementation immediately, or anyway before putting out a new release. For users the migration from one implementation to another will be quite trivial and having both versions around will only confuse them.
I don't mind if you want to remove the legacy part within this PR or in a subsequent one, that's up to you and both alternatives are ok for me. I just have a small preference in removing the old stuff in this PR because in this way we will have the integration tests running also against those removals and be sure that none of the old parts is still in use.
Also don't forget to update documentation accordingly.
Already part of this PR!
I believe there is a conversation in the issue for this PR about that. This PR deprecated all the Quarkus-specific implementations. I'll soon work on one (couple of weeks) that will remove it. |
If so it's ok for me to merge this PR. /cc @geoand |
@mariofusco / @geoand See #1735 for work for removing the Quarkus-specific implementation. I'm at an event this week so I will start working on it next week. |
Refactor to use upstream guardrails (instead of #1619).
For now I'm leaving the existing Quarkus-specific implementation in place, but fully deprecated. We can decide if we'd like to rip it out as part of this PR, or have both implementations for a little bit of time in order to give people time to transition.