Skip to content

Conversation

edeandrea
Copy link
Collaborator

@edeandrea edeandrea commented Aug 28, 2025

Refactor to use upstream guardrails (instead of #1619).

For now I'm leaving the existing Quarkus-specific implementation in place, but fully deprecated. We can decide if we'd like to rip it out as part of this PR, or have both implementations for a little bit of time in order to give people time to transition.

@edeandrea edeandrea requested a review from a team as a code owner August 28, 2025 15:00
@geoand
Copy link
Collaborator

geoand commented Aug 28, 2025

cc @mariofusco

This comment has been minimized.

Refactor to use upstream guardrails.

For now I'm leaving the existing Quarkus-specific implementation in place, but fully deprecated. We can decide if we'd like to rip it out as part of this PR, or have both implementations for a little bit of time in order to give people time to transition.

Closes quarkiverse#1284
@edeandrea edeandrea force-pushed the incorporate-upstream-guardrails branch from abcaac9 to cbb10d7 Compare August 28, 2025 17:15
Copy link

quarkus-bot bot commented Aug 28, 2025

Status for workflow Build (on pull request)

This is the status report for running Build (on pull request) on commit cbb10d7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand requested a review from mariofusco August 29, 2025 06:08
Copy link
Collaborator

@mariofusco mariofusco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edeandrea thanks a lot, amazing job!

I strongly suggest to remove the old guardrails implementation immediately, or anyway before putting out a new release. For users the migration from one implementation to another will be quite trivial and having both versions around will only confuse them.

I don't mind if you want to remove the legacy part within this PR or in a subsequent one, that's up to you and both alternatives are ok for me. I just have a small preference in removing the old stuff in this PR because in this way we will have the integration tests running also against those removals and be sure that none of the old parts is still in use.

Also don't forget to update documentation accordingly.

@edeandrea
Copy link
Collaborator Author

Also don't forget to update documentation accordingly.

Already part of this PR!

I strongly suggest to remove the old guardrails implementation immediately, or anyway before putting out a new release

I believe there is a conversation in the issue for this PR about that. This PR deprecated all the Quarkus-specific implementations. I'll soon work on one (couple of weeks) that will remove it.

@mariofusco
Copy link
Collaborator

I strongly suggest to remove the old guardrails implementation immediately, or anyway before putting out a new release

I believe there is a conversation in the issue for this PR about that. This PR deprecated all the Quarkus-specific implementations. I'll soon work on one (couple of weeks) that will remove it.

If so it's ok for me to merge this PR. /cc @geoand

@geoand geoand merged commit 79463fd into quarkiverse:main Sep 1, 2025
77 checks passed
@edeandrea edeandrea deleted the incorporate-upstream-guardrails branch September 1, 2025 23:48
@edeandrea
Copy link
Collaborator Author

@mariofusco / @geoand See #1735 for work for removing the Quarkus-specific implementation. I'm at an event this week so I will start working on it next week.

@edeandrea edeandrea restored the incorporate-upstream-guardrails branch September 2, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor guardrails once they are moved upstream
3 participants