-
Notifications
You must be signed in to change notification settings - Fork 73
Refactoring #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring #270
Conversation
8211932
to
6c88898
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks. Do we need a test for structure_only = TRUE
?
2620af3
to
008b07b
Compare
I added a test. |
008b07b
to
4620c49
Compare
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
+ Coverage 92.87% 92.93% +0.05%
==========================================
Files 28 28
Lines 1123 1132 +9
==========================================
+ Hits 1043 1052 +9
Misses 80 80
Continue to review full report at Codecov.
|
4620c49
to
bdf5628
Compare
- Adapt documentation (#290). - Add roundtrip (#287). - Fix AppVeyor builds. - Fix token insertion / comment interaction (#279). - Clarify labelling strategy (#285). - Fixing and extending Rstudioaddins (#283). - Fix eq assign parsing (#276). - style_files -> vectorized style_file (#273). - Refactoring (#270). - Fix CI (#275). - Fix covr (#274). - Renaming files (#271). - Handle styling of an unsaved active file (#243). - Test R 3.1 and R 3.2 (#249). - Allow empty {} without line break (#261). - Wrap expr in expr before enclosing with curly braces (#263). - Avoid checking for hard-coded dot (#262). - Account for dependency renaming (utf8 changed to enc) (#264). - Indention of function declaration and closing braces (#260). - Only remove line break before closing with strict option (#252).
Required for #259.