Skip to content

Refactoring #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 8, 2017
Merged

Refactoring #270

merged 6 commits into from
Nov 8, 2017

Conversation

lorenzwalthert
Copy link
Collaborator

Required for #259.

@lorenzwalthert lorenzwalthert requested a review from krlmlr November 2, 2017 13:34
Copy link
Member

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. Do we need a test for structure_only = TRUE?

@lorenzwalthert
Copy link
Collaborator Author

I added a test.

@codecov-io
Copy link

codecov-io commented Nov 8, 2017

Codecov Report

Merging #270 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   92.87%   92.93%   +0.05%     
==========================================
  Files          28       28              
  Lines        1123     1132       +9     
==========================================
+ Hits         1043     1052       +9     
  Misses         80       80
Impacted Files Coverage Δ
R/parse.R 100% <ø> (ø) ⬆️
R/initialize.R 97.5% <100%> (-0.07%) ⬇️
R/relevel.R 100% <100%> (ø) ⬆️
R/token-create.R 100% <100%> (ø) ⬆️
R/nested_to_tree.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ebf31c...bdf5628. Read the comment docs.

@lorenzwalthert lorenzwalthert merged commit a6886fa into r-lib:master Nov 8, 2017
@lorenzwalthert lorenzwalthert deleted the refactoring branch November 8, 2017 19:00
krlmlr added a commit that referenced this pull request Nov 27, 2017
- Adapt documentation (#290).
- Add roundtrip (#287).
- Fix AppVeyor builds.
- Fix token insertion / comment interaction (#279).
- Clarify labelling strategy (#285).
- Fixing and extending Rstudioaddins (#283).
- Fix eq assign parsing (#276).
- style_files -> vectorized style_file (#273).
- Refactoring (#270).
- Fix CI (#275).
- Fix covr (#274).
- Renaming files (#271).
- Handle styling of an unsaved active file (#243).
- Test R 3.1 and R 3.2 (#249).
- Allow empty {} without line break (#261).
- Wrap expr in expr before enclosing with curly braces (#263).
- Avoid checking for hard-coded dot (#262).
- Account for dependency renaming (utf8 changed to enc) (#264).
- Indention of function declaration and closing braces (#260).
- Only remove line break before closing with strict option (#252).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants