Fixing and extending Rstudioaddins #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the selection overwritten with the styled expression is the initial region. If the styled expression is shorter than the initial expression (and the reference is the length of the new expression), it may happen that some of the old code will still be below the newly inserted expression.
lorenzwalthert
force-pushed
the
rstudioaddin
branch
from
ae3cdca to
6e43d55
Compare
krlmlr
approved these changes
Nov 19, 2017
krlmlr
added a commit
that referenced
this pull request
Nov 27, 2017
- Adapt documentation (#290). - Add roundtrip (#287). - Fix AppVeyor builds. - Fix token insertion / comment interaction (#279). - Clarify labelling strategy (#285). - Fixing and extending Rstudioaddins (#283). - Fix eq assign parsing (#276). - style_files -> vectorized style_file (#273). - Refactoring (#270). - Fix CI (#275). - Fix covr (#274). - Renaming files (#271). - Handle styling of an unsaved active file (#243). - Test R 3.1 and R 3.2 (#249). - Allow empty {} without line break (#261). - Wrap expr in expr before enclosing with curly braces (#263). - Avoid checking for hard-coded dot (#262). - Account for dependency renaming (utf8 changed to enc) (#264). - Indention of function declaration and closing braces (#260). - Only remove line break before closing with strict option (#252).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #282 and #281. Styling done "the bare way" instead of with
style_text().rstudioapi::getActiveDocumentContext()does not give the extension, so we try as if it was a.Rfile and if it does not work, we advise the user to save the file so the extension is known when styling is attempted the second time. Then, if it is neither.Rnor.Rmd, we throw an error saying we don't support file types other than.Rand.Rmd.