R 1.0.0 #296

lorenzwalthert · 2017-12-05T17:58:29Z

Not to be merged. Aims to close #145.

codecov-io · 2017-12-05T17:58:46Z

Codecov Report

Merging #296 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #296   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files          30       30           
  Lines        1326     1326           
=======================================
  Hits         1213     1213           
  Misses        113      113

Impacted Files	Coverage Δ
R/indent.R	`95.38% <ø> (ø)`	⬆️
R/ui.R	`100% <ø> (ø)`	⬆️
R/initialize.R	`97.5% <ø> (ø)`	⬆️
R/nested_to_tree.R	`100% <100%> (ø)`	⬆️
R/style_guides.R	`98.13% <100%> (ø)`	⬆️
R/serialized_tests.R	`72.44% <100%> (ø)`	⬆️
R/set-assert-args.R	`79.31% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf08eec...285dba4. Read the comment docs.

lorenzwalthert · 2017-12-05T22:50:49Z

This is the result from devtools::build_win(). Just this one note

checking CRAN incoming feasibility ... NOTE

https://win-builder.r-project.org/0uoMp9FDVJVz/00check.log

All the other things from #145 are incorporated, so I think we are ready for the submission. Do we need to state this other note separately, i.e. per built environment? Also why is there no note about the fact that this is a new release?

lorenzwalthert · 2017-12-05T22:52:54Z

Also, @krlmlr can you update the pkgdown page before the submission?

lorenzwalthert · 2017-12-05T23:06:24Z

For NEWS.md: Do we throw away all previous entries in the file so only the API description is left?

krlmlr

A few more minor nits, we might need to review initialize_attributes.

krlmlr · 2017-12-05T22:52:51Z

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: styler
-Title: Non-invasive Pretty Printing of R code
-Version: 0.0-11
+Title: Non-Invasive Pretty Printing of R code


winbuilder complains that "code" needs to be capitalized too.

krlmlr · 2017-12-05T22:53:04Z

NEWS.md

- Create and serialize nested parse data.
- Internal support for indention of expressions with parentheses.
- Adding and removing spaces around operators on flat parse data.
+## styler 0.1.0 (2017-12-05)


1.0.0 now, I forgot to update.

krlmlr · 2017-12-05T22:54:34Z

NEWS.md

+style_text(text, ..., style = tidyverse_style, transformers = style(...))
+```
+
+### style guide creators


I think for a user the tidyverse_style() function is more important than create_style_guide().

Ok, moved them up.

krlmlr · 2017-12-05T22:56:10Z

NEWS.md

+This function is used to create a style guide.
+```
+create_style_guide(
+  initialize = initialize_attributes, 


What is initialize_attributes? It should be either exported (and then perhaps be a function like default_style_guide_attributes()), or initialize should accept a default argument of NULL.

Yes, thanks, forgot about that. I think we may rename it to default_style_guide_attributes() then and export it.

Does this need an update?

krlmlr · 2017-12-05T22:57:03Z

NEWS.md

+
+These are helper functions that simply forward to the helper functions above.
+```
+tidyverse_reindention()


Maybe add these two to the "style guides" section?

krlmlr · 2017-12-05T23:20:37Z

Yes, we can remove old news.

Added deploy key and restarted Travis job https://travis-ci.org/r-lib/styler/jobs/311941953, which should update pkgdown.

krlmlr · 2017-12-05T23:24:53Z

Restarted job https://travis-ci.org/r-lib/styler/jobs/311951016 instead, this is the correct 0.0-11 release.

krlmlr · 2017-12-06T00:05:36Z

Built pkgdown manually, for some reason the rebuild on Travis CI doesn't catch all changes.

lorenzwalthert · 2017-12-06T17:02:26Z

Can't figure out why the appveyor buid fails now. Maybe currently updating to 3.4.3?

lorenzwalthert · 2017-12-06T19:49:40Z

New winbuild results
https://win-builder.r-project.org/81q44YxOBi0k/

checking CRAN incoming feasibility ... NOTE

Code is now capitalised in the DESCRIPTION, so everything should be fine now.

krlmlr

Awesome, almost ready to go! I think we can ignore AppVeyor failures for now, krlmlr/r-appveyor#99.

krlmlr · 2017-12-06T21:57:43Z

NEWS.md

+This function is used to create a style guide.
+```
+create_style_guide(
+  initialize = initialize_attributes, 


Does this need an update?

lorenzwalthert · 2017-12-06T22:50:08Z

I also rephrased the help file for default_style_guide_attributes().

lorenzwalthert · 2017-12-07T21:02:50Z

Are we set for the release?

lorenzwalthert · 2017-12-07T21:03:56Z

Should we also style the source code with styler prior to the CRAN submission?

krlmlr

I think so.

krlmlr · 2017-12-07T22:23:38Z

NEWS.md

+This function is used to create a style guide.
+```
+create_style_guide(
+  initialize = default_style_guide_attributes, 


Do we need parens here?

No there must not be braces, see the example in the docs

set_line_break_before_curly_opening <- function(pd_flat) { op <- pd_flat$token %in% "'{'" pd_flat$lag_newlines[op] <- 1L pd_flat } set_line_break_before_curly_opening_style <- function() { create_style_guide(line_break = set_line_break_before_curly_opening) } style_text("a <- function(x) { ! x }", style = set_line_break_before_curly_opening_style)

I hope the following is clear enough:

#' @param line_break A list of transformer functions that manipulate line_break #' information.

The other arguments are described in a similar fashion.

Do you think it's clear enough or should we describe each of these arguments more explicitly, i.e. like this:

#' @param line_break A list of bare transformer function names that manipulate #' line_break information.

Oh, I see. Makes sense.

krlmlr · 2017-12-07T22:46:53Z

I don't mind postponing styling styler until after the CRAN release, but we can do it if you like.

krlmlr and others added 7 commits December 5, 2017 17:36

bump version to 0.1.0

a230432

prepare release

adb5e6a

bump

5315d02

R CMD check

79f3f21

use && instead of &

bd27568

skip on windows, not just on appveyor.

9e1ded3

more documentation in NEWS.md

2df0f28

lorenzwalthert force-pushed the r-1.0.0 branch from 186e05a to c23e8e5 Compare December 5, 2017 21:46

lorenzwalthert added 2 commits December 5, 2017 22:49

remove documentation for unexported functions

88c1ca4

adding examples to all exported functions

7c1a50d

lorenzwalthert force-pushed the r-1.0.0 branch from 31b803b to 7c1a50d Compare December 5, 2017 21:49

lorenzwalthert requested a review from krlmlr December 5, 2017 22:25

krlmlr reviewed Dec 5, 2017

View reviewed changes

lorenzwalthert added 2 commits December 6, 2017 17:24

rename and export initialize_attributes

3dc7ea9

Rearranging news

c665894

lorenzwalthert force-pushed the r-1.0.0 branch from 2a4c554 to c665894 Compare December 6, 2017 16:26

lorenzwalthert added 2 commits December 6, 2017 17:30

add documentation with example

e492134

Don't describe initializers in the exported function.

a7b47ff

lorenzwalthert requested a review from krlmlr December 6, 2017 17:01

lorenzwalthert removed the request for review from krlmlr December 6, 2017 17:07

rename to default_style_guide_attributes

9164083

lorenzwalthert requested a review from krlmlr December 6, 2017 19:41

krlmlr reviewed Dec 6, 2017

View reviewed changes

update news

2a5199a

lorenzwalthert requested a review from krlmlr December 7, 2017 21:03

Rephrase helpfile.

e133152

lorenzwalthert force-pushed the r-1.0.0 branch from c62de00 to e133152 Compare December 7, 2017 21:05

lorenzwalthert mentioned this pull request Dec 7, 2017

Style with styler #297

Merged

add test environment

285dba4

krlmlr approved these changes Dec 7, 2017

View reviewed changes

lorenzwalthert merged commit a113c94 into r-lib:master Dec 8, 2017

lorenzwalthert mentioned this pull request Dec 8, 2017

R 1.0.0 (into r-1.0.0 instead of master) #298

Merged

R 1.0.0 #296

R 1.0.0 #296

Uh oh!

Conversation

lorenzwalthert commented Dec 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Dec 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lorenzwalthert commented Dec 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lorenzwalthert commented Dec 5, 2017

Uh oh!

lorenzwalthert commented Dec 5, 2017

Uh oh!

krlmlr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lorenzwalthert Dec 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

krlmlr commented Dec 5, 2017

Uh oh!

krlmlr commented Dec 5, 2017

Uh oh!

krlmlr commented Dec 6, 2017

Uh oh!

lorenzwalthert commented Dec 6, 2017

Uh oh!

lorenzwalthert commented Dec 6, 2017

Uh oh!

krlmlr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lorenzwalthert commented Dec 6, 2017

Uh oh!

lorenzwalthert commented Dec 7, 2017

Uh oh!

lorenzwalthert commented Dec 7, 2017

Uh oh!

krlmlr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

krlmlr commented Dec 7, 2017

lorenzwalthert commented Dec 5, 2017 •

edited

Loading

codecov-io commented Dec 5, 2017 •

edited

Loading

lorenzwalthert commented Dec 5, 2017 •

edited

Loading

lorenzwalthert Dec 6, 2017 •

edited

Loading