Skip to content

CRAN-ready for 1.0.0 #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
12 tasks done
lorenzwalthert opened this issue Aug 22, 2017 · 8 comments · Fixed by #296
Closed
12 tasks done

CRAN-ready for 1.0.0 #145

lorenzwalthert opened this issue Aug 22, 2017 · 8 comments · Fixed by #296
Labels
Complexity: Medium Priority: High Type: Infrastructure
Milestone
CRAN (styler 1.0.0)

Comments

@lorenzwalthert
Copy link
Collaborator

lorenzwalthert commented Aug 22, 2017 •
edited
Loading

  • Get rid of notes.
  • Consider changing api tests to not format in temp dir since it creates problems with appveyor.
  • Make tests passing quickly enough?
  • Wait for krlmlr/utf8 to be released on CRAN and remove Remotes: in DESCRIPTION
  • Clarify LICENCE with usethis()? (Link)
  • Completing cran-release-notes.md
  • Update NEWS.md (describe every exported function in order of relevance, see pillar).
  • Create a pre-release.
  • Bump version to 0.1.0
  • devtools::check_spelling()
  • Delete all man files for unexported functions.
  • Make sure every man page of exported functions has an example.
@lorenzwalthert lorenzwalthert added this to the CRAN milestone Aug 22, 2017
@lorenzwalthert lorenzwalthert mentioned this issue Aug 22, 2017
Merged
@lorenzwalthert
Copy link
Collaborator Author

@krlmlr What else do we need to do here?

@krlmlr
Copy link
Member

krlmlr commented Aug 23, 2017

We need to release utf8. How long are the tests running, will this be a problem for CRAN?

@lorenzwalthert
Copy link
Collaborator Author

It takes about one minute on my machine. In the CRAN Submission Policy it only says:

Checking the package should take as little CPU time as possible, as the CRAN check farm is a very limited resource and there are thousands of packages. Long-running tests and vignette code can be made optional for checking, but do ensure that the checks that are left do exercise all the features of the package.

So I don't really know what that means but I think one minute is too much. Can we define a few tests that cover all rules?

krlmlr added a commit that referenced this issue Aug 24, 2017
@krlmlr
Merge pull request #146 from lorenzwalthert/customizing_vignette
096851d 
- Vignette on customizing styler (#145).
krlmlr added a commit that referenced this issue Aug 24, 2017
@krlmlr
Merge tag 'v0.0-8'
e1130f8 
- Vignette on customizing styler (#145).
- No line break after `switch()` and friends (#152).
- Remove flat relicts completely (#151).
- Don't reindent function calls and break line correctly for multi-line calls (#149).
- Set space between "=" and "," (#150).
- Make R CMD Check perfect (#148).
- Adding tests for exception handling with invalid parse data (#139).
- Fix indention by checking for all potential triggers (#142).
- Fix un-indention (#135).
- Support wide characters (#130).
- No spaces around :, :: and :::.
- Redesigning the API (#123).
- Solve eq_sub indention in general (#125).
- Minor refactorings.
- Re-indent token-dependent (#119).
- Supporting more indention patterns.
- Allow raw indention.
- Definitively fixing eol issue with comments.
- Infrastructure.
- Flattening out the parse table.
- New rule: no space after ! -> !!! for tidyeval.
- Fix spacing around '{'.
- Don't drop tokens! Fixes #101.
- EOL spaces in empty comments (and in general) (#98).
- mal-indention in conditional statement due to wrong specification of indent_without_paren) (#95).
- Complicated indentions based on arithmetic and special operators (#96).
- indention interaction on with assignment operator and other operators (#97).
@lorenzwalthert lorenzwalthert mentioned this issue Aug 30, 2017
Closed
@hadley
Copy link
Member

hadley commented Oct 12, 2017

A minute should be ok

@lorenzwalthert
Copy link
Collaborator Author

@krlmlr can you tell me whether we need to further specify the licence (see this link)?

@krlmlr
Copy link
Member

krlmlr commented Nov 27, 2017

I think the license entry in DESCRIPTION is fine.

@lorenzwalthert
Copy link
Collaborator Author

Coo, thanks. One more check.

@krlmlr
Copy link
Member

krlmlr commented Nov 27, 2017

I updated NEWS, but we should start from scratch for the first CRAN release. For pillar, another new release, I started with the API file and briefly described each entry point.

@lorenzwalthert lorenzwalthert mentioned this issue Dec 5, 2017
Merged
@lorenzwalthert lorenzwalthert changed the title make package CRAN-ready CRAN-ready for 1.0.0 Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complexity: Medium Priority: High Type: Infrastructure
Projects
None yet
Milestone
CRAN (styler 1.0.0)
Development

Successfully merging a pull request may close this issue.

R 1.0.0 lorenzwalthert/styler
3 participants
@hadley @krlmlr @lorenzwalthert