Skip to content

EOL spaces not dropped anymore #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lorenzwalthert opened this issue Jul 28, 2017 · 2 comments · Fixed by #99
Closed

EOL spaces not dropped anymore #98

lorenzwalthert opened this issue Jul 28, 2017 · 2 comments · Fixed by #99

Comments

@lorenzwalthert
Copy link
Collaborator

Since we removed gsub() calls, as discussed in #85, EOL spaces were not removed anymore.

library(styler)
nchar(style_text("#' "))
#> [1] 3
@lorenzwalthert lorenzwalthert mentioned this issue Jul 28, 2017
Merged
@krlmlr
Copy link
Member

krlmlr commented Jul 28, 2017

Only for comments, or also for regular code?

@lorenzwalthert
Copy link
Collaborator Author

Also for regular code, but it is solved with #99.

lorenzwalthert added a commit that referenced this issue Jul 28, 2017
@lorenzwalthert
Merge pull request #99 from lorenzwalthert/op_assignment_indention
3b09707 
fixing
- EOL spaces in empty comments (and in general) (#98).
- mal-indention in conditional statement due to wrong specification of indent_without_paren) (#95).
- complicated indentions based on arithmetic and special operators (#96).
- indention interaction on with assignment operator and other operators (#97).
krlmlr added a commit that referenced this issue Aug 24, 2017
@krlmlr
Merge tag 'v0.0-8'
e1130f8 
- Vignette on customizing styler (#145).
- No line break after `switch()` and friends (#152).
- Remove flat relicts completely (#151).
- Don't reindent function calls and break line correctly for multi-line calls (#149).
- Set space between "=" and "," (#150).
- Make R CMD Check perfect (#148).
- Adding tests for exception handling with invalid parse data (#139).
- Fix indention by checking for all potential triggers (#142).
- Fix un-indention (#135).
- Support wide characters (#130).
- No spaces around :, :: and :::.
- Redesigning the API (#123).
- Solve eq_sub indention in general (#125).
- Minor refactorings.
- Re-indent token-dependent (#119).
- Supporting more indention patterns.
- Allow raw indention.
- Definitively fixing eol issue with comments.
- Infrastructure.
- Flattening out the parse table.
- New rule: no space after ! -> !!! for tidyeval.
- Fix spacing around '{'.
- Don't drop tokens! Fixes #101.
- EOL spaces in empty comments (and in general) (#98).
- mal-indention in conditional statement due to wrong specification of indent_without_paren) (#95).
- Complicated indentions based on arithmetic and special operators (#96).
- indention interaction on with assignment operator and other operators (#97).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Op assignment indention lorenzwalthert/styler
2 participants
@krlmlr @lorenzwalthert