Op assignment indention #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the assignment operators requires flattening from right, flatten_operators_one was completely redesigned. The flattening itself was outsourced to flatten_pd(), which can flatten from right or left. Within flatten_pd, binding together a parse table and its child was outsourced to bind_with_child
interaction between math tokens and special tokens and assignment
krlmlr
approved these changes
Jul 28, 2017
R/modify_pd.R
Outdated
| @@ -23,16 +23,17 @@ indent_curly <- function(pd, indent_by) { | |||
|
|
|||
| #' @rdname update_indention | |||
| indent_op <- function(pd, indent_by, token = c(math_token, | |||
| "SPECIAL-PIPE")) { | |||
| "SPECIAL-PIPE", | |||
| "LEFT_ASSIGN", " | |||
R/relevel.R
Outdated
| @@ -12,19 +12,55 @@ flatten_operators <- function(pd_nested) { | |||
| post_visit(c(flatten_operators_one)) | |||
| } | |||
|
|
|||
|
|
|||
| #' Flaten one level of nesting with its child | |||
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=========================================
Coverage ? 91.77%
=========================================
Files ? 18
Lines ? 596
Branches ? 0
=========================================
Hits ? 547
Misses ? 49
Partials ? 0
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=========================================
Coverage ? 91.77%
=========================================
Files ? 18
Lines ? 596
Branches ? 0
=========================================
Hits ? 547
Misses ? 49
Partials ? 0
Continue to review full report at Codecov.
|
lorenzwalthert
added a commit
to lorenzwalthert/styler
that referenced
this pull request
Jan 15, 2022
lorenzwalthert
added a commit
to lorenzwalthert/styler
that referenced
this pull request
Jan 15, 2022
lorenzwalthert
added a commit
to lorenzwalthert/styler
that referenced
this pull request
Jan 15, 2022
lorenzwalthert
added a commit
to lorenzwalthert/styler
that referenced
this pull request
Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing:
#97 and #96 was a bit complicated since solving the problem required to further flatten the nested parse tables.