Skip to content

Fix alignment detection for quoted keys #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 23, 2021

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Dec 23, 2021

Closes #881. Towards #258.

@codecov-commenter
Copy link

Codecov Report

Merging #882 (4833340) into main (c2e25f9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage   89.75%   89.76%           
=======================================
  Files          47       47           
  Lines        2499     2500    +1     
=======================================
+ Hits         2243     2244    +1     
  Misses        256      256           
Impacted Files Coverage Δ
R/detect-alignment-utils.R 90.62% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e25f9...4833340. Read the comment docs.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 539f7a1 is merged into main:

  •   :ballot_box_with_check:cache_applying: 31.9ms -> 32ms [-0.34%, +0.81%]
  •   :rocket:cache_recording: 1.15s -> 1.15s [-0.65%, -0.02%]
  •   :ballot_box_with_check:without_cache: 3.04s -> 3.04s [-0.53%, +0.34%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert merged commit b96d188 into r-lib:main Dec 23, 2021
@lorenzwalthert lorenzwalthert deleted the issue-881 branch December 23, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always have a single space surrounding argument specification?
2 participants