chore: upgrade to stable2412#417
Merged
Merged
Conversation
Co-authored-by: Daanvdplas <daanvdplas@live.nl> Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
Contributor
|
Not important but when uplifting the Newer versions remove this check so we should use |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #417 +/- ##
==========================================
- Coverage 71.41% 71.28% -0.14%
==========================================
Files 72 72
Lines 13568 13626 +58
Branches 13568 13626 +58
==========================================
+ Hits 9690 9713 +23
- Misses 3605 3646 +41
+ Partials 273 267 -6
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
al3mart
approved these changes
Jan 21, 2025
al3mart
left a comment
Member
There was a problem hiding this comment.
Looks good!
Things like default weight usage can, and should, be addressed outside of this PR with the changes coming with the mainnet runtime review:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.