Skip to content

chore: upgrade to stable2412#417

Merged
peterwht merged 5 commits into
mainfrom
chore-upgrade-pop-net-to-stable2412/sc-1940
Jan 21, 2025
Merged

chore: upgrade to stable2412#417
peterwht merged 5 commits into
mainfrom
chore-upgrade-pop-net-to-stable2412/sc-1940

Conversation

@peterwht

@peterwht peterwht commented Jan 3, 2025

Copy link
Copy Markdown
Collaborator

Co-authored-by: Daanvdplas <daanvdplas@live.nl>
Co-authored-by: Daan van der Plas <93204684+Daanvdplas@users.noreply.github.com>
@peterwht peterwht marked this pull request as draft January 3, 2025 19:28
@chungquantin

Copy link
Copy Markdown
Contributor

Not important but when uplifting the contracts-parachain, there is a different setting for MaxCodeLen for pallet-revive that we need to pay attention: r0gue-io/contracts-parachain#12 (comment)

Newer versions remove this check so we should use stable2412 version of pallet-revive.

@codecov-commenter

codecov-commenter commented Jan 17, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 17.53247% with 127 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.28%. Comparing base (e56b78f) to head (558eac2).
⚠️ Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
node/src/service.rs 0.00% 20 Missing ⚠️
node/src/command.rs 0.00% 16 Missing ⚠️
runtime/devnet/src/config/api/versioning.rs 0.00% 15 Missing ⚠️
runtime/testnet/src/config/api/versioning.rs 0.00% 15 Missing ⚠️
runtime/testnet/src/lib.rs 0.00% 15 Missing ⚠️
runtime/mainnet/src/lib.rs 12.50% 14 Missing ⚠️
runtime/devnet/src/lib.rs 0.00% 13 Missing ⚠️
node/src/chain_spec.rs 0.00% 6 Missing ⚠️
node/src/rpc.rs 0.00% 2 Missing ⚠️
pallets/nfts/src/features/transfer.rs 0.00% 2 Missing ⚠️
... and 6 more
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
- Coverage   71.41%   71.28%   -0.14%     
==========================================
  Files          72       72              
  Lines       13568    13626      +58     
  Branches    13568    13626      +58     
==========================================
+ Hits         9690     9713      +23     
- Misses       3605     3646      +41     
+ Partials      273      267       -6     
Files with missing lines Coverage Δ
extension/src/lib.rs 94.23% <100.00%> (ø)
extension/src/mock.rs 96.00% <ø> (+0.79%) ⬆️
pallets/api/src/fungibles/tests.rs 99.69% <100.00%> (-0.01%) ⬇️
pallets/api/src/mock.rs 100.00% <ø> (+4.16%) ⬆️
pallets/nfts/src/common_functions.rs 90.25% <100.00%> (ø)
runtime/common/src/lib.rs 11.53% <100.00%> (ø)
runtime/devnet/src/config/api/mod.rs 69.04% <ø> (ø)
runtime/devnet/src/config/contracts.rs 84.21% <100.00%> (+0.87%) ⬆️
runtime/mainnet/src/config/xcm.rs 100.00% <ø> (ø)
runtime/testnet/src/config/api/mod.rs 69.04% <ø> (ø)
... and 17 more

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peterwht peterwht marked this pull request as ready for review January 21, 2025 15:00
@Daanvdplas Daanvdplas self-requested a review January 21, 2025 18:51

@Daanvdplas Daanvdplas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@al3mart al3mart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Things like default weight usage can, and should, be addressed outside of this PR with the changes coming with the mainnet runtime review:

@peterwht peterwht merged commit 8c4c564 into main Jan 21, 2025
@peterwht peterwht deleted the chore-upgrade-pop-net-to-stable2412/sc-1940 branch January 21, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants