chore: uplift to polkadot 2412#425
Merged
peterwht merged 21 commits intoJan 21, 2025
Merged
Conversation
peterwht
changed the base branch from
main
to
chore-upgrade-pop-net-to-stable2412/sc-1940
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## chore-upgrade-pop-net-to-stable2412/sc-1940 #425 +/- ##
===============================================================================
- Coverage 71.35% 71.28% -0.07%
===============================================================================
Files 72 72
Lines 13592 13626 +34
Branches 13592 13626 +34
===============================================================================
+ Hits 9698 9713 +15
- Misses 3627 3646 +19
Partials 267 267
|
This was referenced Jan 12, 2025
Daanvdplas
reviewed
Jan 14, 2025
Daanvdplas
left a comment
Daanvdplas
left a comment
Collaborator
There was a problem hiding this comment.
Changes looking good, I faced a similar issue with the integration tests when I made similar changes to the Cargo.toml file. Left a few things and also curious what the order of things will be with the linked PRs?
…nstead of then_some https://github.com/paritytech/polkadot-sdk/pull/6156/files#diff-7ab065c73b2237dff7c6eca18162b7f674e5e7f9e330af668cc5d35de6a597bd https://github.com/paritytech/polkadot-sdk/pull/5919/files#diff-7b805930c8caa346a498254e233963501862a29b4ae5633a00efb96b9c96258a paritytech/polkadot-sdk#5693 paritytech/polkadot-sdk@b76e91a
peterwht
force-pushed
the
peterwht/chore-polkadot-2412
branch
from
029a3a9 to
937ca11
Compare
peterwht
commented
Jan 17, 2025
al3mart
reviewed
Jan 17, 2025
al3mart
left a comment
al3mart
left a comment
Member
There was a problem hiding this comment.
The uplift looks pretty good! looking forward to seeing the CI green!
As it has been discussed off github there are a few improvements that can be made to the mainnet runtime. But having this PR only taking care of the sdk sync makes sense to me.
I'm happy to take care of working on pushing those runtime changes, @peterwht
This was referenced Jan 20, 2025
Daanvdplas
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uplifts to Stable 2412.
Due to dependency issues with
asset-hub-westend-runtimewith the 2412 release,integration-testshave been included from the workspace. The integration tests have been updated and confirmed to pass.Relevant PRs causing node changes
Relevant PRs causing runtime changes
sp_runtime::RuntimeStringand replace withCow<'static, str>orStringdepending on use case paritytech/polkadot-sdk#5693TransactionExtensionas a replacement forSignedExtensionparitytech/polkadot-sdk#3685dispatch_infochanging to holdcall_weightandextension_weightTODOs (in follow up PRs, non-blocking for this PR)
TransactionExtensionas a replacement forSignedExtensionparitytech/polkadot-sdk#3685