Introduce PublicationAddress.TryParse and switch BasicProperties.ReplyToAddress to use it#831
Merged
michaelklishin merged 9 commits intomasterfrom May 12, 2020
Merged
Conversation
…ge-properties-do-not-throw"" This reverts commit ed65854. See the discussion in #827. We will slightly tweak the approach but at the very least the test added by @ig-sinicyn can be retained.
instead of changing the behavior of an existing one. Per discussion with @bording and @ig-sinicyn in #827.
michaelklishin
changed the title
Contributor
Author
|
@bording @ig-sinicyn is my interpretation of the |
ig-sinicyn
reviewed
May 11, 2020
lukebakken
requested changes
May 11, 2020
Collaborator
lukebakken
left a comment
lukebakken
left a comment
There was a problem hiding this comment.
Code formatting is very odd ... is this visual studio code?
ig-sinicyn
reviewed
May 11, 2020
lukebakken
requested changes
May 11, 2020
bording
reviewed
May 11, 2020
Contributor
Author
|
Ready for another round. |
lukebakken
approved these changes
May 11, 2020
Collaborator
lukebakken
left a comment
lukebakken
left a comment
There was a problem hiding this comment.
👍 from me. I would appreciate a quick glance from @bording (no hurry!)
bording
reviewed
May 11, 2020
bording
approved these changes
May 11, 2020
Collaborator
bording
left a comment
bording
left a comment
There was a problem hiding this comment.
Made a suggestion for a change, but it's just a simplification.
michaelklishin
added a commit
that referenced
this pull request
May 12, 2020
Introduce PublicationAddress.TryParse and switch BasicProperties.ReplyToAddress to use it (cherry picked from commit 9f0e9f5)
Collaborator
|
@bording as always, thanks for your input! |
This was referenced Jul 29, 2025
This was referenced Sep 15, 2025
This was referenced Oct 20, 2025
This was referenced Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This is an alternative to #828 (with @ig-sinicyn's test case retained for credit) which does
not change the behavior of
PublicationAddress.Parseand instead introducesPublicationAddress.TryParsewhich is then used byBasicProperties.ReplyToAddress.Types of Changes
Checklist
CONTRIBUTING.mddocument