Skip to content

4.3: Mark transient_nonexcl_queues as denied_by_default#15459

Merged
michaelklishin merged 2 commits into
mainfrom
loic-denied_by_default2
Mar 10, 2026
Merged

4.3: Mark transient_nonexcl_queues as denied_by_default#15459
michaelklishin merged 2 commits into
mainfrom
loic-denied_by_default2

Conversation

@lhoguin

@lhoguin lhoguin commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@lhoguin
lhoguin force-pushed the loic-denied_by_default2 branch 2 times, most recently from a5e068e to f45ce3a Compare March 3, 2026 13:28
Comment thread deps/amqp_client/src/amqp_rpc_server.erl
@lhoguin
lhoguin force-pushed the loic-denied_by_default2 branch from 01c238e to 07ea66e Compare March 6, 2026 16:03
Thanks Diana for most of the shovel fixes, and JSP for assisting
in fixing the callback.
@lhoguin
lhoguin force-pushed the loic-denied_by_default2 branch from 5045887 to 9b3b332 Compare March 9, 2026 15:01
@lhoguin lhoguin changed the title DO NOT MERGE Mark transient_nonexcl_queues as denied_by_default 4.3: Mark transient_nonexcl_queues as denied_by_default Mar 9, 2026
@lhoguin
lhoguin marked this pull request as ready for review March 9, 2026 15:15

@michaelklishin michaelklishin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One rabbit_local_shovel change results in server-named durable queues being used when a shovel source is an exchange (that uses a one-off transient queue for consumption).

Such queues are then leaked.

Comment thread deps/rabbitmq_shovel/src/rabbit_local_shovel.erl Outdated
@dcorbacho
dcorbacho force-pushed the loic-denied_by_default2 branch from c3dc01d to 1c94a8f Compare March 10, 2026 07:54

@michaelklishin michaelklishin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @dcorbacho, for switching shovels to use client-named queues with exchange sources.

@michaelklishin michaelklishin added this to the 4.3.0 milestone Mar 10, 2026
@michaelklishin
michaelklishin merged commit 78f9d7e into main Mar 10, 2026
184 checks passed
@michaelklishin
michaelklishin deleted the loic-denied_by_default2 branch March 10, 2026 14:17
acogoluegnes added a commit to rabbitmq/rabbitmq-jms-client that referenced this pull request Mar 13, 2026
Transient, non-exclusive queues no longer permitted on RabbitMQ 4.3.

References rabbitmq/rabbitmq-server#15459
acogoluegnes added a commit to rabbitmq/rabbitmq-jms-client that referenced this pull request Mar 13, 2026
Transient, non-exclusive queues no longer permitted on RabbitMQ 4.3.

References rabbitmq/rabbitmq-server#15459

(cherry picked from commit 9ce7997)
github-actions Bot pushed a commit to rabbitmq/rabbitmq-jms-client that referenced this pull request Mar 13, 2026
Transient, non-exclusive queues no longer permitted on RabbitMQ 4.3.

References rabbitmq/rabbitmq-server#15459
github-actions Bot pushed a commit to rabbitmq/rabbitmq-jms-client that referenced this pull request Mar 13, 2026
Transient, non-exclusive queues no longer permitted on RabbitMQ 4.3.

References rabbitmq/rabbitmq-server#15459

(cherry picked from commit 9ce7997)
acogoluegnes added a commit to rabbitmq/rabbitmq-perf-test that referenced this pull request Mar 13, 2026
acogoluegnes added a commit to rabbitmq/rabbitmq-perf-test that referenced this pull request Mar 13, 2026
acogoluegnes added a commit to rabbitmq/hop that referenced this pull request Mar 23, 2026
They are no longer allowed in RabbitMQ 4.3 (they must be
durable+exclusive or transient+exclusive).

References rabbitmq/rabbitmq-server#15459
acogoluegnes added a commit to rabbitmq/rabbitmq-perf-test that referenced this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants