Repository navigation
fix: align Qwen3 router precision and P2P staging (after cutoff) - #3697
Open
yueming-yuan wants to merge 2 commits into
Open
yueming-yuan wants to merge 2 commits into
yueming-yuan wants to merge 2 commits into
Conversation
yueming-yuan
requested review from
Shi-Dong,
Zhichenzzz,
fzyzcjy,
guapisolo,
jybsuper and
maocheng23
as code owners
September 24, 2026 23:44
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
This was referenced Sep 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defer the Qwen3-MoE router precision change from #3584 until after the v0.1.1 cutoff. Requires the FP32 router support retained in SGLang #40997.
Two files, +7/-1; the moved patches are unchanged. This affects full-model Qwen3 as well as LoRA. The SGLang expert-index bounds and complete fused shared-expert fixes are in cutoff PR #41074.
Validation: full local pre-commit passed. Earlier Qwen full-model CI exercised these patches in #3584; the CPU P2P reproduction distinguishes the old BF16 staging mismatch from exact FP32 transfer. The new branch/dependency combination has not run GPU CI. P2P CI also logs transfer failures on unmodified main; final weight impact is not established.
Model tracking and release split.
ci-sglang-pr: 0a08c70dc89e196d0ebc59084af24c10999b6934
ci-megatron-pr: 651dd728e3c1f763b5ba3a8de4ac0d01f70e621c