Repository navigation
fix: support explicit Qwen3 MoE router precision (after cutoff) - #40997
Open
yueming-yuan wants to merge 37 commits into
Open
yueming-yuan wants to merge 37 commits into
yueming-yuan wants to merge 37 commits into
Conversation
yueming-yuan
requested review from
BBuf,
DarkSharpness,
Fridge003,
HaiShaw,
HydraQYH,
Ying1123,
celve,
jybsuper,
lifuhuang,
yuan-luo and
yushengsu-thu
as code owners
September 24, 2026 08:06
7 of 15 tasks
This was referenced Sep 24, 2026
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
guapisolo
requested review from
ByronHsu,
Duyi-Wang,
ShangmingCai,
YAMY1234,
hebiao064,
hubertlu-tw,
kkHuang-amd,
rainj-me,
sogalin and
yizhang2077
as code owners
October 2, 2026 06:45
yueming-yuan
force-pushed
the
yueming/qwen3-router-dtype
branch
from
October 2, 2026 17:23
30d5019 to
0a08c70
Compare
guapisolo
force-pushed
the
sglang-miles
branch
from
October 17, 2026 00:28
7b6993a to
9d86e91
Compare
guapisolo
requested review from
AgainstEntropy,
alphabetc1,
hanming-lu,
huangtingwei9988,
hzh0425,
kevin-mii,
niehen6174,
ping1jing2 and
yichiche
as code owners
October 17, 2026 00:28
Rockdu
force-pushed
the
sglang-miles
branch
2 times, most recently
from
October 31, 2026 06:43
865cb64 to
29b34bc
Compare
guapisolo
force-pushed
the
sglang-miles
branch
from
November 1, 2026 02:54
29b34bc to
b0ed761
Compare
This was referenced Nov 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support explicit FP32 Qwen3-MoE router logits. Deferred until after the v0.1.1 cutoff, paired with Miles #3697.
Gate weights and inputs use FP32 only when configured. Covers normal, DeepEP, MegaMoE and staged execution; defaults remain unchanged. Reject unsupported dtypes and quantized-gate overrides. One file, +15/-4.
The expert-index bounds and complete fused shared-expert pool/loading fixes have moved to cutoff PR #41074. Rebased onto the current
sglang-milesbase; only the router changes remain.Validation: real-weight router replay covered 6 layers × 2 dtypes × 3 execution paths. Earlier Miles #3584 Qwen full-model CI exercised the router configuration and exposed the paired P2P staging fix now in #3697. Full local pre-commit passed after rebasing. A CPU probe of all four production gate-call expressions passes in default and FP32 modes; before the added MegaMoE cast it fails with a BF16/FP32 matmul mismatch. This is call-site coverage, not MegaMoE GPU execution. Fresh rebased-head GPU CI and throughput validation remain pending.
Model tracking and release split.
CI States
Latest PR Test (Base): ❌ Run #37040379385
Latest PR Test (Extra): ❌ Run #37040378777
Latest PR Test (AMD ROCm 10): ❌ Run #37040379094