better exception for cv.imencode #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 89.50% 89.49% -0.02%
==========================================
Files 36 36
Lines 5165 5167 +2
==========================================
+ Hits 4623 4624 +1
- Misses 542 543 +1 ☔ View full report in Codecov by Sentry. |
Hexer10
reviewed
Jun 3, 2024
| if (!success.value) { | ||
| throw CvException(ErrorCode.StsError.code, msg: "imencode failed, check your params"); | ||
| } | ||
| calloc.free(cExt); |
There was a problem hiding this comment.
@rainyl shouldn't the free happen before the success.value check? currently cExt wont be freed if imencode fails
Owner
Author
There was a problem hiding this comment.
Oh, you are right, will be fixed soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#68