Skip to content

better exception for cv.imencode #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rainyl merged 2 commits into from
Jun 1, 2024
Merged

better exception for cv.imencode #69

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60257e7
better exception for cv.imencode
rainyl Jun 1, 2024
89bf7a4
fix free string in cv.imencode
rainyl Jun 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/src/imgcodecs/imgcodecs.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ Uint8List imencode(
if (!success.value) {
throw CvException(ErrorCode.StsError.code, msg: "imencode failed, check your params");
}
calloc.free(cExt);
Copy link

@Hexer10 Hexer10 Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rainyl shouldn't the free happen before the success.value check? currently cExt wont be freed if imencode fails

Copy link
Owner Author

@rainyl rainyl Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you are right, will be fixed soon

return VecUChar.fromPointer(buffer).toU8List();
}

Expand Down