[core] improve auth_mode=token UX#58737
Merged
Merged
Conversation
added 2 commits
November 18, 2025 09:21
Signed-off-by: sampan <sampan@anyscale.com>
Signed-off-by: sampan <sampan@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the user experience for token-based authentication by introducing a new RayAuthenticationError exception, which provides clearer error messages and a link to the documentation. The changes are well-structured and improve code clarity. I've provided a few suggestions to further enhance maintainability by removing an unused parameter and improving a docstring.
Signed-off-by: sampan <sampan@anyscale.com>
Signed-off-by: sampan <sampan@anyscale.com>
…er-cuts Signed-off-by: sampan <sampan@anyscale.com>
edoakes
reviewed
Nov 19, 2025
Signed-off-by: sampan <sampan@anyscale.com>
…into auth-paper-cuts
Collaborator
|
Updated dashboard dialogue: 
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ray-gardener
Bot
added
docs
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
…into auth-paper-cuts
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
edoakes
approved these changes
Nov 19, 2025
edoakes
added a commit
to edoakes/ray
that referenced
this pull request
Nov 19, 2025
- introduce new exception class for authentication related exceptions (`ray.exceptions.AuthenticationError`) - add docs link in auth exception - fix minor papercuts - use `RAY_LOG(FATAL)` instead of `RAY_CHECK` to avoid including `An unexpected system state has occurred. You have likely discovered a bug in Ray ...` in error message - update dashboard dialogue - update ray start error message --------- Signed-off-by: sampan <sampan@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: sampan <sampan@anyscale.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
aslonnie
pushed a commit
that referenced
this pull request
Nov 19, 2025
Cherry pick: #58737 Signed-off-by: sampan <sampan@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Sampan S Nayak <sampansnayak2@gmail.com> Co-authored-by: sampan <sampan@anyscale.com>
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Nov 21, 2025
- introduce new exception class for authentication related exceptions (`ray.exceptions.AuthenticationError`) - add docs link in auth exception - fix minor papercuts - use `RAY_LOG(FATAL)` instead of `RAY_CHECK` to avoid including `An unexpected system state has occurred. You have likely discovered a bug in Ray ...` in error message - update dashboard dialogue - update ray start error message --------- Signed-off-by: sampan <sampan@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: sampan <sampan@anyscale.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
ykdojo
pushed a commit
to ykdojo/ray
that referenced
this pull request
Nov 27, 2025
- introduce new exception class for authentication related exceptions (`ray.exceptions.AuthenticationError`) - add docs link in auth exception - fix minor papercuts - use `RAY_LOG(FATAL)` instead of `RAY_CHECK` to avoid including `An unexpected system state has occurred. You have likely discovered a bug in Ray ...` in error message - update dashboard dialogue - update ray start error message --------- Signed-off-by: sampan <sampan@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: sampan <sampan@anyscale.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
SheldonTsen
pushed a commit
to SheldonTsen/ray
that referenced
this pull request
Dec 1, 2025
- introduce new exception class for authentication related exceptions (`ray.exceptions.AuthenticationError`) - add docs link in auth exception - fix minor papercuts - use `RAY_LOG(FATAL)` instead of `RAY_CHECK` to avoid including `An unexpected system state has occurred. You have likely discovered a bug in Ray ...` in error message - update dashboard dialogue - update ray start error message --------- Signed-off-by: sampan <sampan@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: sampan <sampan@anyscale.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
- introduce new exception class for authentication related exceptions (`ray.exceptions.AuthenticationError`) - add docs link in auth exception - fix minor papercuts - use `RAY_LOG(FATAL)` instead of `RAY_CHECK` to avoid including `An unexpected system state has occurred. You have likely discovered a bug in Ray ...` in error message - update dashboard dialogue - update ray start error message --------- Signed-off-by: sampan <sampan@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: sampan <sampan@anyscale.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ray.exceptions.AuthenticationError)RAY_LOG(FATAL)instead ofRAY_CHECKto avoid includingAn unexpected system state has occurred. You have likely discovered a bug in Ray ...in error message