-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[core] improve auth_mode=token UX #58737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
c3070ff
[core] improve auth_mode=token UX
bd3fdc8
fix lint issues
79769f4
address comments + fix lint
0fb406e
Merge branch 'master' of https://github.com/ray-project/ray into auth…
edoakes a4ca4a2
replace RAY_CHECK with RAY_LOG(FATAL)
eece5d3
Merge remote-tracking branch 'upstream/auth-paper-cuts' into auth-pap…
fed02af
WIP
edoakes 1c71878
Merge branch 'master' of https://github.com/ray-project/ray into auth…
edoakes 3a9d2d3
cleanups
edoakes 7a7f0f0
cleanups
edoakes a179568
remove redundant token check
a50f08f
dashboard
edoakes 323d488
Merge branch 'auth-paper-cuts' of https://github.com/ray-project/ray …
edoakes 9fa5928
fix msg
edoakes b1146ff
fix
edoakes e996731
Merge branch 'master' into auth-paper-cuts
edoakes b4ecb26
Merge branch 'master' of https://github.com/ray-project/ray into auth…
edoakes f1c45e1
fix UI test
edoakes dbb6c4f
Merge branch 'auth-paper-cuts' of https://github.com/ray-project/ray …
edoakes 2399740
fix UI test
edoakes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 4 additions & 20 deletions
24
python/ray/_private/authentication/authentication_constants.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| """Tests for Ray exceptions.""" | ||
| import pytest | ||
|
|
||
| from ray.exceptions import RayAuthenticationError, RayError | ||
|
|
||
|
|
||
| class TestRayAuthenticationError: | ||
| """Tests for RayAuthenticationError exception.""" | ||
|
|
||
| auth_doc_url = "https://docs.ray.io/en/latest/ray-security/auth.html" | ||
|
|
||
| def test_basic_creation(self): | ||
| """Test basic RayAuthenticationError creation.""" | ||
| error = RayAuthenticationError("Token is missing") | ||
| error_str = str(error) | ||
|
|
||
| assert "Token is missing" in error_str | ||
| assert self.auth_doc_url in error_str | ||
|
|
||
| def test_is_ray_error_subclass(self): | ||
| """Test that RayAuthenticationError is a RayError subclass.""" | ||
| error = RayAuthenticationError("Test") | ||
| assert isinstance(error, RayError) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| import sys | ||
|
|
||
| sys.exit(pytest.main(["-v", __file__])) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.