Skip to content

Translate: component titles, descriptions, buttons, tags and more #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

hanseul-lee
Copy link
Contributor

@hanseul-lee hanseul-lee commented Jul 27, 2023

Progress

ChangeLog

사이트 내 다양한 컴포넌트에서 사용되는 타이틀, 설명, 버튼명, 태그 등의 번역을 추가하였습니다.

No. Desc Path (src/components) Screenshot
1 이전,다음 버튼 DocsFooter.tsx 이전,다음
2 피드백 Layout/Feedback.tsx 피드백
3 챌린지 MDX/Challenges/Challenge.tsx
MDX/Challenges/Challenges.tsx
챌린지1
챌린지2
4 예제 MDX/Challenges/Challenge.tsx 예제
5 callout 제목

cf. #632
MDX/ExpandableCallout.tsx 주의하세요2중요합니다
6 자세히 보기 버튼 MDX/ExpandableExample.tsx 자세히보기
7 더 배우기 MDX/MDXComponents.tsx 더배우기
8 학습 내용 MDX/MDXComponents.tsx 학습내용이장에서는
9 요약 MDX/Recap.tsx 요약
10 태그 Tag.tsx tag1tag2

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.96 KB (🟡 +261 B) 180.11 KB
/500 76.95 KB (🟡 +261 B) 180.1 KB
/[[...markdownPath]] 78.63 KB (🟡 +261 B) 181.78 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@@ -104,21 +104,19 @@ export function Challenge({
{showSolution && (
<div className="mt-6">
<h3 className="text-2xl font-bold text-primary dark:text-primary-dark">
Solution
해설
Copy link
Contributor Author

@hanseul-lee hanseul-lee Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

버튼과 타이틀에서 모두 Solution이라고 표기되어 있지만
문맥상 본문의 타이틀에는 '해설'로, 버튼에는 '정답'으로 번역해 두었습니다.
괜찮은지 확인해 주시면 감사하겠습니다.

  • 버튼: 정답 보기(Show solution)
  • 제목: 해설(Solution)

cf.
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다. 매우 꼼꼼하시네요 👍

@@ -43,7 +43,7 @@ const variantMap = {
'linear-gradient(rgba(249, 247, 243, 0), rgba(249, 247, 243, 1)',
},
wip: {
title: 'Under Construction',
title: '개발중이에요',
Copy link
Contributor Author

@hanseul-lee hanseul-lee Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

callout은 #632 에서 논의된 용어로 정의해 두었습니다!

다만 Glossary에 적혀있는 개발중이에요의 경우,
맞춤법 검사 시 개발 중이에요가 올바른 표기라고 나오는데 이 부분 수정이 필요할지 확인해주시면 감사하겠습니다.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞춤법 검사에 맞는 표현으로 맞추는게 맞을 것 같아요 👀 이건 다른곳도 동일한지라 별도의 PR로 반영해도 좋을 것 같습니다.

Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hg-pyun hg-pyun merged commit c894c6a into reactjs:main Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants