-
-
Notifications
You must be signed in to change notification settings - Fork 462
Translate: component titles, descriptions, buttons, tags and more #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Three Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
@@ -104,21 +104,19 @@ export function Challenge({ | |||
{showSolution && ( | |||
<div className="mt-6"> | |||
<h3 className="text-2xl font-bold text-primary dark:text-primary-dark"> | |||
Solution | |||
해설 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다. 매우 꼼꼼하시네요 👍
@@ -43,7 +43,7 @@ const variantMap = { | |||
'linear-gradient(rgba(249, 247, 243, 0), rgba(249, 247, 243, 1)', | |||
}, | |||
wip: { | |||
title: 'Under Construction', | |||
title: '개발중이에요', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맞춤법 검사에 맞는 표현으로 맞추는게 맞을 것 같아요 👀 이건 다른곳도 동일한지라 별도의 PR로 반영해도 좋을 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Progress
ChangeLog
사이트 내 다양한 컴포넌트에서 사용되는 타이틀, 설명, 버튼명, 태그 등의 번역을 추가하였습니다.
MDX/Challenges/Challenges.tsx
cf. #632