-
-
Notifications
You must be signed in to change notification settings - Fork 462
Translate: component titles, descriptions, buttons, tags and more #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,15 +18,15 @@ interface ExpandableCalloutProps { | |
|
||
const variantMap = { | ||
deprecated: { | ||
title: 'Deprecated', | ||
title: '더 이상 사용되지 않습니다', | ||
Icon: IconWarning, | ||
containerClasses: 'bg-red-5 dark:bg-red-60 dark:bg-opacity-20', | ||
textColor: 'text-red-50 dark:text-red-40', | ||
overlayGradient: | ||
'linear-gradient(rgba(249, 247, 243, 0), rgba(249, 247, 243, 1)', | ||
}, | ||
note: { | ||
title: 'Note', | ||
title: '중요합니다!', | ||
Icon: IconNote, | ||
containerClasses: | ||
'bg-green-5 dark:bg-green-60 dark:bg-opacity-20 text-primary dark:text-primary-dark text-lg', | ||
|
@@ -43,7 +43,7 @@ const variantMap = { | |
'linear-gradient(rgba(249, 247, 243, 0), rgba(249, 247, 243, 1)', | ||
}, | ||
wip: { | ||
title: 'Under Construction', | ||
title: '개발중이에요', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 맞춤법 검사에 맞는 표현으로 맞추는게 맞을 것 같아요 👀 이건 다른곳도 동일한지라 별도의 PR로 반영해도 좋을 것 같습니다. |
||
Icon: IconNote, | ||
containerClasses: 'bg-yellow-5 dark:bg-yellow-60 dark:bg-opacity-20', | ||
textColor: 'text-yellow-50 dark:text-yellow-40', | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
버튼과 타이틀에서 모두
Solution
이라고 표기되어 있지만문맥상 본문의 타이틀에는 '해설'로, 버튼에는 '정답'으로 번역해 두었습니다.
괜찮은지 확인해 주시면 감사하겠습니다.
정답 보기(Show solution)
해설(Solution)
cf.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다. 매우 꼼꼼하시네요 👍