Improve tutorial documentation; fixes #71 #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 5a975b8 |
|
Yep, understandable :) I'll review in a sec. |
|
@bvaughn, that should be it I hope :) |
bvaughn
reviewed
Oct 16, 2017
content/tutorial/tutorial.md
Outdated
|
|
||
| ```bash | ||
| touch src/index.js | ||
| curl -L https://codepen.io/gaearon/pen/oWWQNa.js > src/index.js |
There was a problem hiding this comment.
I just noticed that this JS is compiled. That's probably not ideal.
I'm thinking maybe we should just remove these 2 touch+curl snippets, at least unless there's a way to get the pre-compilation JS. Thoughts?
There was a problem hiding this comment.
Hm, yes, you're right. Should have paid more attention to that. Do you feel we should remove the touches as well, or just the curls?
There was a problem hiding this comment.
Eh...probably both? Might be confusing to have the touch without the curl.
There was a problem hiding this comment.
Cool. I'll remove in a sec.
Because codepen was providing us with compiled javascript, it'd be best to leave the curl request snippets out of the tutorial. related to: #71
bvaughn
approved these changes
Oct 16, 2017
|
Thanks~ |
jhonmike
pushed a commit
to jhonmike/reactjs.org
that referenced
this pull request
Jul 1, 2020
* Translate React Conf Recap. * Update content/blog/2018-11-13-react-conf-recap.md Changed the term 'Simultânea' to 'Concorrente'. Co-Authored-By: DanielObara <[email protected]> * Update content/blog/2018-11-13-react-conf-recap.md Co-Authored-By: DanielObara <[email protected]> * Update content/blog/2018-11-13-react-conf-recap.md Co-Authored-By: DanielObara <[email protected]> * Update content/blog/2018-11-13-react-conf-recap.md Co-Authored-By: DanielObara <[email protected]>
BetterZxx
pushed a commit
to BetterZxx/react.dev
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.