Export RedisClientType and RedisClusterType types #1704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.ts
Outdated
| @@ -1,10 +1,14 @@ | |||
| import RedisClient from './lib/client'; | |||
| import RedisCluster from './lib/cluster'; | |||
|
|
|||
| export { RedisClientType } from './lib/client'; | |||
|
@kjlis : We kind of need this feature as well - but it seems like in this PR there are some merge conflicts currently. If not I can offer to take it over from here, if you don't mind of course 🙂 |
|
@davelosert I'll rebase with the latest changes and update the PR |
Codecov Report
@@ Coverage Diff @@
## master #1704 +/- ##
=======================================
Coverage 94.43% 94.43%
=======================================
Files 300 300
Lines 3075 3075
Branches 427 427
=======================================
Hits 2904 2904
Misses 93 93
Partials 78 78
Continue to review full report at Codecov.
|
leibale
suggested changes
Nov 26, 2021
|
@leibale the workflow failed with the timeout error: Is it a transient error? If so, can we rerun the workflow? |
leibale
approved these changes
Nov 29, 2021
|
@kjlis thanks! :) |
leibale
added a commit
that referenced
this pull request
Dec 13, 2021
* update workflows & README * add .deepsource.toml * fix client.quit, add error events on cluster, fix some "deepsource.io" warnings * Release 4.0.0-rc.1 * add cluster.duplicate, add some tests * fix #1650 - add support for Buffer in some commands, add GET_BUFFER command * fix GET and GET_BUFFER return type * update FAQ * Update invalid code example in README.md (#1654) * Update invalid code example in README.md * Update README.md Co-authored-by: Leibale Eidelman <[email protected]> * fix #1652 * ref #1653 - better types * better types * fix 5412479 * Update GEOSEARCHSTORE.spec.ts * fix #1660 - add support for client.HSET('key', 'field', 'value') * upgrade dependencies, update README * fix #1659 - add support for db-number in client options url * fix README, remove unused import, downgrade typedoc & typedoc-plugin-markdown * update client-configurations.md * fix README * add CLUSTER_SLOTS, add some tests * fix "createClient with url" test with redis 5 * remove unused imports * Release 4.0.0-rc.2 * add missing semicolon * replace empty "transformReply" functions with typescript "declare" * fix EVAL & EVALSHA, add some tests, npm update * fix #1665 - add ZRANGEBYLEX, ZRANGEBYSCORE, ZRANGEBYSCORE_WITHSCORES * new issue templates * add all COMMAND commands * run COMMAND & COMMAND INFO tests only on redis >6 * Create SECURITY.md * fix #1671 - add support for all client configurations in cluster * ref #1671 - add support for defaults * remove some commands from cluster, npm update, clean code, * lock benny version * fix #1674 - remove `isolationPoolOptions` when creating isolated connection * increase test coverage * update .npmignore * Release 4.0.0-rc.3 * fix README * remove whitespace from LICENSE * use "export { x as y }" instead of import & const * move from "NodeRedis" to "Redis" * fix #1676 * update comments * Auth before select database (#1679) * Auth before select database * fix #1681 Co-authored-by: leibale <[email protected]> * Adds connect-as-acl-user example. (#1684) * Adds connect-as-acl-user example. * Adds blank line at end. * Set to private. * Adds examples folder to npmignore. * Adds Apple .DS_Store file to .gitignore (#1685) * Adds Apple .DS_Store file. * Add .DS_Store to .npmignore too Co-authored-by: Leibale Eidelman <[email protected]> * move examples * clean some tests * clean code * Adds examples table of contents and contribution guidelines. (#1686) * Updated examples to use named functions. (#1687) * Updated examples to user named functions. * Update README.md Co-authored-by: Leibale Eidelman <[email protected]> * update docs, add 6.0.x to the tests matrix, add eslint, npm update, fix some commands, fix some types Co-authored-by: Simon Prickett <[email protected]> * fix tests with redis 6.0.x * fix ACL GETUSER test * fix client.quit and client.disconnect * fix ACL GETUSER * Adds TypeScript note and corrects a typo. * Fixes a bug in the Scan Iterator section. (#1694) * Made examples use local version. * Add `lua-multi-incr.js` example (#1692) Also fix syntax error in the lua example in the README Closes #1689. * Add(examples): Create an example for blPop & lPush (#1696) * Add(examples): Create an example for blPop & lPush Signed-off-by: Aditya Rastogi <[email protected]> * Update(examples): fix case, add timeout, update readme Signed-off-by: Aditya Rastogi <[email protected]> Closes #1693. * Add command-with-modifiers.js example (#1695) * Adds TypeScript note and corrects a typo. * Adds command-with-modifiers example. (#1688) * Adds command-with-modifiers example. (#1688) * Adds command-with-modifiers example. (#1688) * Removed callbacks. Co-authored-by: Simon Prickett <[email protected]> Closes #1688. * Issue # 1697 FIX - creates an example script that shows how to use the SSCAN iterator (#1699) * #1697 fix for set scan example * adds the js file * adds comment * Minor layout and comment adjustment. Co-authored-by: srawat2 <shashank19aug> Co-authored-by: Simon Prickett <[email protected]> Closes #1697. * fix #1706 - HSET return type should be number * use dockers for tests, fix some bugs * increase dockers timeout to 30s * release drafter (#1683) * release drafter * fixing contributors * use dockers for tests, use npm workspaces, add rejson & redisearch modules, fix some bugs * fix #1712 - fix LINDEX return type * uncomment TIME tests * use codecov * fix tests.yml * uncomment "should handle live resharding" test * fix #1714 - update README(s) * add package-lock.json * update CONTRIBUTING.md * update examples * uncomment some tests * fix test-utils * move "all-in-one" to root folder * fix tests workflow * fix bug in cluster slots, enhance live resharding test * fix live resharding test * fix #1707 - handle number arguments in legacy mode * Add rejectedUnauthorized and other TLS options (#1708) * Update socket.ts * fix #1716 - decode username and password from url * fix some Z (sorted list) commands, increase commands test coverage * remove empty lines * fix 'Scenario' typo (#1720) * update readmes, add createCluster to the `redis` package * add .release-it.json files, update some md files * run tests on pull requests too * Support esModuleInterop set to false. (#1717) * Support esModuleInterop set to false. When testing the upcoming 4.x release, we got a bunch of typescript errors emitted from this project. We quickly realized this is because the library uses the esModuleInterop flag. This makes some imports _slightly_ easier to write, but it comes at a cost: it forces any application or library using this library to *also* have esModuleInterop on. The `esModuleInterop` flag is a bit of a holdover from an earlier time, and I would not recommend using it in libraries. The main issue is that if it's set to true, you are forcing any users of the library to also have `esModuleInterop`, where if you keep have it set to `false` (the default), you leave the decision to the user. This change should have no rammifications to users with `esModuleInterop` on, but it will enable support for those that have it off. This is especially good for library authors such as myself, because I would also like to keep this flag off to not force *my* users into this feature. * All tests now pass! * Move @types/redis-parser into client sub-package and removed a comma * npm update, remove html from readme * add tests and licence badges * update changelog.md * update .npmignore and .release-it.json * update .release-it.json * Release [email protected] * revert d32f1ed * fix .npmignore * replace @redis with @node-redis * Release [email protected] * update json & search version * Release [email protected] * Release [email protected] * update dependencies * Release [email protected] * fix #1724 - fix LINDEX signature * add positive test for LINDEX * fix #1718 - add support for buffers in pubsub * Fixed a few typos. * fix ARRPOP * fix #1726 * enhance cluster reshard handling * Adds RediSearch demo. * Adds intro sentence. * Made top level comment more descriptive. * Adds RedisJSON example. * Renamed JSON search example. * Some refactoring. * Fixed search example for JSON. * Minor wording updates. * Added missing pet name. * Adds JSON package overview. * Fixed typo. * Search package README initial version. * remove echo from docker entrypoint.sh * npm update * update docs * fix merge * fix merge * Release [email protected] * npm update * Release [email protected] * update sub modules * Release [email protected] * update README * Fixed `zScanIterator` example (#1733) The example for `zScanIterator` had the wrong values in the `for` loop. * fix #1738 - add support for buffers in HSET * fix for c96a0dd - remove .only from HSET tests * increase HSET test coverage * fix for d0de622 * ref #1741 - fix socket options type * fix #1741 - change default to `localhost` and update docs * fix #1739 - add support for number as value in HSET * fix tests workflow * increase pushGeoCountArgument test coverage * init time series * Update v3-to-v4.md (#1737) * Update v3-to-v4.md * Update v3-to-v4.md * Update v3-to-v4.md * Update docs/v3-to-v4.md Co-authored-by: Simon Prickett <[email protected]> * Update docs/v3-to-v4.md Co-authored-by: Simon Prickett <[email protected]> * Update docs/v3-to-v4.md Co-authored-by: Simon Prickett <[email protected]> * Update docs/v3-to-v4.md Co-authored-by: Simon Prickett <[email protected]> * Update docs/v3-to-v4.md Co-authored-by: Simon Prickett <[email protected]> * Update docs/v3-to-v4.md Co-authored-by: Simon Prickett <[email protected]> Co-authored-by: Leibale Eidelman <[email protected]> Co-authored-by: Simon Prickett <[email protected]> * fix #1744 - add npm minimum version * fix #1743 - restrict the list of published files (#1742) * fix TS.CREATERULE * fix #1673 - Export RedisClientType and RedisClusterType types (#1704) * add description to package.json * fix #1749 - FT.SEARCH SORTBY * Client: Export errors (#1750) * Client: Export errors * export RedisModules & RedisScripts as well Co-authored-by: Leibale Eidelman <[email protected]> * fix for 592714f - "fix tests" * fix for a453114 - fix FT.SEARCH * fix FT.SEARCH * improve encodeCommand performance, add set-get-delete-string benchmark * fix encodeCommand * Add the `event` doc (#1753) * hdr-histogram-js * fix #1764 - fix PubSub resubscribe * fix #1758 - implement some CLIENT commands, add `name` to `RedisClientOptions` * update tests badge link * update license badge link * ref #1765 - support lowercase command names in legacy mode * update benchmarks * fix LINSERT test title * fix v4 benchmarks * fix discord link * fix #1771 - fix PubSub resubscribe * fix #1766 - allow .quit() in PubSub mode * fix for e112568 - should not retry connecting if failed due to wrong auth * Add LGTM (#1773) * Update README.md * Update README.md Co-authored-by: Leibale Eidelman <[email protected]> * fix #1734 - fix PubSub unsubscribe race condition * Support RedisTimeSeries (#1757) * Implement missing commands and add test * Update DECRBY.spec.ts * Small changes * clean code * Update MGET_WITHLABELS.ts Use map in transformReply Co-authored-by: leibale <[email protected]> * fix #1774 #1767 - update docs Co-authored-by: Chayim <[email protected]> * Search commands (#1778) * ft.alter * ft.profile * clean code * fix generated documentation * fix documentation workflow * fix documentation workflow * fix documentation workflow * update CHANGELOG * Release [email protected] * update tsconfig.json * Release [email protected] * Release [email protected] * fix time-series .release-it.json * add @node-redis/time-series to README * add time-series to all in one * Release [email protected] Co-authored-by: Richard Samuelsson <[email protected]> Co-authored-by: mustard <[email protected]> Co-authored-by: Simon Prickett <[email protected]> Co-authored-by: Simon Prickett <[email protected]> Co-authored-by: Suze Shardlow <[email protected]> Co-authored-by: Joshua T <[email protected]> Co-authored-by: Aditya Rastogi <[email protected]> Co-authored-by: Rohan Kumar <[email protected]> Co-authored-by: Kalki <[email protected]> Co-authored-by: Chayim <[email protected]> Co-authored-by: Da-Jin Chu <[email protected]> Co-authored-by: Henrique Corrêa <[email protected]> Co-authored-by: Evert Pot <[email protected]> Co-authored-by: AnnAngela <[email protected]> Co-authored-by: Damien Arrachequesne <[email protected]> Co-authored-by: kjlis <[email protected]> Co-authored-by: Vojta Staněk <[email protected]> Co-authored-by: Guy Korland <[email protected]> Co-authored-by: Avital Fine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Export RedisClientType and RedisClusterType types
Fixes #1673
Checklist
npm testpass with this change (including linting)?