Added async recorders and registry by vladvildanov · Pull Request #3950 · redis/redis-py

vladvildanov · 2026-02-10T13:32:20Z

Description of change

Please provide a description of the change here.

Pull Request check-list

Please make sure to review and check all of these items:

Do tests and lints pass with this change?
Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
Is the new or changed code fully tested?
Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

vladvildanov · 2026-02-10T13:33:59Z

augment review

augmentcode · 2026-02-10T13:37:02Z

🤖 Augment PR Summary

Summary: Adds an asyncio observability recorder layer so redis-py’s async clients can emit OpenTelemetry metrics using the existing provider/config.

Changes:

Introduced a new redis.asyncio.observability package with an async recorder module mirroring the sync recorder API.
Implemented async wrappers around RedisMetricsCollector for command duration, connection lifecycle, resiliency, Pub/Sub, and streaming-lag metrics.
Added connection-count observable gauge support via the shared ObservablesRegistry.
Normalized Pub/Sub channel attributes (including bytes-to-str) and honored hide-channel / hide-stream configuration flags.
Updated redis.observability.registry to avoid a hard runtime dependency on OpenTelemetry’s Observation type.
Added a comprehensive asyncio test suite validating recorder passthrough behavior, observable-gauge flow, and RESP2/RESP3 streaming-lag parsing.

Technical Notes: Collector/config are retrieved from the shared observability provider manager; initialization is lazy and intended to no-op when telemetry is disabled or OTel isn’t installed.

_{🤖 Was this summary useful? React with 👍 or 👎}

augmentcode

Review completed. 4 suggestions posted.

Comment augment review to trigger a new review at any time.

redis/asyncio/observability/recorder.py

tests/test_asyncio/test_observability/test_recorder.py

redis/asyncio/observability/__init__.py

vladvildanov · 2026-02-11T09:09:38Z

augment review

augmentcode

Review completed. 6 suggestions posted.

Comment augment review to trigger a new review at any time.

redis/asyncio/observability/recorder.py

tests/test_asyncio/test_observability/test_recorder.py

vladvildanov · 2026-02-11T09:46:55Z

augment review

augmentcode

Review completed. 3 suggestions posted.

Comment augment review to trigger a new review at any time.

redis/asyncio/observability/recorder.py

tests/test_asyncio/test_observability/test_recorder.py

petyaslavova

LGTM.

* Added intrastructure and integration point with OTel (#3864) * Added intrastructure and integration point with OTel * Added check for enabled metric groups * Applied comments * Added export of operation duration metric (#3881) * Added stadalone client metrics export * Added support for cluster client * Removed unused dispatchers and test * Added export of resiliency metrics (#3888) * Added stadalone client metrics export * Added support for cluster client * Added error metric export on fail commands for standalone client * Removed unused dispatchers and test * Added on error metrics export for cluster * Added export of maint notification count metric * Apply comments * Remove redundant Union * Added export of connection basic metrics (#3891) * Added export of connection basic metrics * Added new error category attribute * Update tests/test_observability/test_recorder.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update tests/test_observability/test_recorder.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply comments * Applied comments --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Added pub/sub and stream lag metrics export (#3898) * Added export of connection basic metrics * Added new error category attribute * Added pub/sub and stream lag metrics export * Added metric export form XREAD * Update redis/client.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update redis/event.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Applied comments --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Added OTel benchmark test (#3903) * Added export of connection basic metrics * Added new error category attribute * Added pub/sub and stream lag metrics export * Added metric export form XREAD * Added benchmark tests * Added error output * Added env variable for otel host * Fixed endpoint * Added iterations and results averaging * Use unsecured gRPC * Added --with-command-metrics argument * Removed incorrect identation * Update benchmarks/otel_benchmark.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update benchmarks/otel_benchmark.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update benchmarks/otel_benchmark.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update benchmarks/otel_benchmark.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update benchmarks/otel_benchmark.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Added export of connection advanced metrics (#3910) * Added export of connection advanced metrics * Update tests/test_connection_pool.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update redis/observability/metrics.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Refactored kwargs instead of args --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Added CSC metrics export (#3911) * Added export of connection advanced metrics * Added CSC metrics export * Revert changes * Added observable gauge registry and refactored observables metric export * Fixed case with trackin non-cachable cache tracking * Added memory and CPU usage (#3933) * Added full benchmark tests + fixes * Added Memory and CPU usage calculation * Removed events dispatching overhead, refactored metrics attributes (#3934) * Removed events dispatching overhead, refactored metrics attributes * Fixed incorrect retry attempts, changed indexes to named parameters * Fixed issue with connection attribute and metric recording * Added async recorders and registry (#3950) * Added async recorders and registry * Removed async registry * Added more coverage * Added bucket override configuration (#3952) * Added async recorders and registry * Added bucket override configuration * Removed async registry * Added more coverage * Fixed version constraints, removed ubused imports * Moved module desription on top of file * Remove async instrumentations (#3953) * Fix tests and codestyle * Fixed missing parameters * Fixed tests * Fixed tests * Fixed tests * Marked argument as unused * Fixed tests * Added missing metric export * Fixes units and pool name attribute Signed-off-by: Elena Kolevska <elena@kolevska.com> * Updated test for pool name attribute Signed-off-by: Elena Kolevska <elena@kolevska.com> * Updates more tests Signed-off-by: Elena Kolevska <elena@kolevska.com> * Linter Signed-off-by: Elena Kolevska <elena@kolevska.com> * Added try...except blocks for recorder functions * Added documentation * Updated wordlist * Update redis/cluster.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update redis/connection.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update redis/connection.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update pyproject.toml Co-authored-by: Elena Kolevska <elena-kolevska@users.noreply.github.com> * Codestyle fixes * Fixed metric export * Fixed assertions * Added geo failover metric export * Codestyle fixes --------- Signed-off-by: Elena Kolevska <elena@kolevska.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Elena Kolevska <elena@kolevska.com> Co-authored-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>

Added async recorders and registry

37688af

vladvildanov requested a review from petyaslavova February 10, 2026 13:32

augmentcode bot reviewed Feb 10, 2026

View reviewed changes

Removed async registry

4cd36d7

augmentcode bot reviewed Feb 11, 2026

View reviewed changes

Added more coverage

b70be43

augmentcode bot reviewed Feb 11, 2026

View reviewed changes

redis/asyncio/observability/recorder.py Show resolved Hide resolved

redis/asyncio/observability/recorder.py Show resolved Hide resolved

tests/test_asyncio/test_observability/test_recorder.py Show resolved Hide resolved

petyaslavova approved these changes Feb 11, 2026

View reviewed changes

vladvildanov merged commit 2f3fd25 into feat/observability Feb 11, 2026
1 check passed

vladvildanov deleted the vv-async-recorders branch February 11, 2026 10:15

Conversation

vladvildanov commented Feb 10, 2026

Description of change

Pull Request check-list

Uh oh!

vladvildanov commented Feb 10, 2026

Uh oh!

augmentcode bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

augmentcode bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vladvildanov commented Feb 11, 2026

Uh oh!

augmentcode bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vladvildanov commented Feb 11, 2026

Uh oh!

augmentcode bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petyaslavova left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

augmentcode bot commented Feb 10, 2026 •

edited

Loading