-
Notifications
You must be signed in to change notification settings - Fork 9
added support for streaming as per issue #5 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'll check and merge this PR at weekend if there is no issue. |
hey, is there a problem with the PR? Anything that needs to be changed, etc... ? |
Sorry for my late reply. For now I just completed the pull request 6. Now I'm taking a look at your PR. Once again, thanks for your support :) |
@Driedas , could you provide me Postman request & controller implementation demo ? I'll check whether it conflicts with the new merged code or not. |
Hey, I'll implement a sample controller, but is Fiddler OK for the sample request? |
@Driedas , yes, fiddler is ok. |
@Driedas , any fiddler example please ? |
I've tested with this one, just change the extension to .har and import into fiddler. |
hey, did you get a chance to look at this? Sorry for pushing, but have one more improvement based on the use of this package in production (support for enums in message contracts) |
Sorry for my late reply (new job, more works :D ) However, when I kept the old source code in
And changed Could you mind telling me any advantages or differences between |
hey, no problem, thanks for sticking with it :) The salient bits that I've added are these: The advantages in using the Below is the difference in the allocated memory on the first line of code in the respective API action methods, when trying to upload a 4MB attachment, ~6MB increase in the memory footprint for the nonstreaming endpoint as opposed to the streaming endpoint (used as baseline on the image) |
Thank you for your info. I'll do some tests with large file and measure IIS server for further information. |
This is my first iteration, seems to work, however am missing some automated tests that at least verify the happy path works.
Do you have any comments/suggestions on stuff to improve/change?