Remove lodash.reduce, lodash.camelCase #166
Conversation
yangmillstheory
changed the title
yangmillstheory
changed the title
| , ''); | ||
| } | ||
|
|
||
| export default actionType => actionType.split(namespacer).map(camelCase).join(namespacer); |
There was a problem hiding this comment.
Let's use the camelCase function from sindresorhus: https://github.com/sindresorhus/camelcase
We could also put this file into a utils folders.
There was a problem hiding this comment.
That doesn't look like it honors delimiters like /. From the PR description
Also, I think it's useful to allow / when camel-casing (and not remove it). This would give users the ability to write namespaced actions (via helper code, e.g.) as in #159.
Honoring delimiters like / would make libraries such as https://github.com/yangmillstheory/redux-nested-actions useful.
Thoughts?
There was a problem hiding this comment.
Fine for me. We should only look if we really covered every possible case.
This reverts commit 4263c44.
|
What is the progress on this? Looks good. |
|
Sorry about the delay! I agree this is mostly done, I'll update this and ship tonight. |
|
https://github.com/acdlite/redux-actions/releases/tag/1.2.1 @ruiaraujo thanks for moving this along |
Going from
to
Also, I think it's useful to allow
/when camel-casing (and not remove it). This would give users the ability to write namespaced actions (via helper code, e.g.) as in #159.