Convert null payloadCreator to the identity #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timche
requested changes
Nov 23, 2016
| isFunction(payloadCreator), | ||
| 'Expected payloadCreator to be a function or undefined' | ||
| isFunction(payloadCreator) || isNull(payloadCreator), | ||
| 'Expected payloadCreator to be a function, undefined, or null' |
| @@ -1,22 +1,27 @@ | |||
| import identity from 'lodash/identity'; | |||
| import isFunction from 'lodash/isFunction'; | |||
| import isUndefined from 'lodash/isUndefined'; | |||
| import isNull from 'lodash/isNull'; | |||
There was a problem hiding this comment.
I'd instead use isNil, so we check for null OR undefined.
There was a problem hiding this comment.
undefined is coerced at the parameter level, so I don't think we need to check for it downstream. Let me know if I'm missing something.
There was a problem hiding this comment.
You are right, didn't see it 👍
timche
approved these changes
Nov 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #169.